keyman icon indicating copy to clipboard operation
keyman copied to clipboard

chore(core): add script action for rebuilding ldml header and move ts from core to common 🙀

Open mcdurdin opened this issue 2 years ago • 1 comments

It is best if we don't have deep deps on core/include/ldml for ts builds. So move the relevant files into common/ somewhere. (This is a bit recursive as well at present because kmc depends on core/include/ldml, but core depends on kmc for building tests, and this change would fix that.)

The .ts file should be a part of common/web/types. The .h file should go in /common/include (and should be .gitignored). ldml-const-builder should go in /common/tools/ldml-const-builder.


i'd put a script action in here for the generation, minor though

Originally posted by @srl295 in https://github.com/keymanapp/keyman/pull/7113#discussion_r953986031

In core/include/ldml/package.json

mcdurdin avatar Aug 25 '22 19:08 mcdurdin

I'm going to bump this to 17.0 because I think I'd like to refactor slightly more -- moving at least the .ts files out of core/ and into common/, as they are shared between Core and Developer. This also removes all typescript from Core, which is neater.

General aim: I am trying to avoid cross reference of individual files across modules, so our dependency map stays clean.

mcdurdin avatar Oct 21 '22 03:10 mcdurdin