keyman icon indicating copy to clipboard operation
keyman copied to clipboard

fix(android): verify browser before starting activity

Open mcdurdin opened this issue 2 years ago • 3 comments

Fixes #6899.

@keymanapp-test-bot skip

mcdurdin avatar Jul 27 '22 05:07 mcdurdin

I could be wrong, but wouldn't this cause a lot of errors to simply become 'silent errors' from the user perspective?

True. This scenario seems unlikely to happen in "real life" -- how many Android devices don't have a browser installed? -- but it happens in the Play Store test environment. I could go ahead and add a toast notification, if you think that is important?

mcdurdin avatar Aug 05 '22 13:08 mcdurdin

I could go ahead and add a toast notification, if you think that is important?

I'm not sure if it's needed for every case, but that does seem to be wise for at least some of them. For example, if the user's already in a WebView (for help, keyboard search, etc), that's definitely worth a notification - otherwise the user'll be like "why isn't this working?"

I can't say that any of the change locations are spots to not include a Toast. I'm just not clear on role a few of the spots play, thus can't really say one way or the other.

jahorton avatar Aug 08 '22 02:08 jahorton

Changes in this pull request will be available for download in Keyman version 16.0.51-alpha

keyman-server avatar Aug 24 '22 18:08 keyman-server