keyman icon indicating copy to clipboard operation
keyman copied to clipboard

feat(developer): VSCode plugin for building 🗼

Open srl295 opened this issue 1 year ago • 6 comments

  • initial checkin
  • README
  • build.sh

Fixes: #12756

@keymanapp-test-bot skip

srl295 avatar Dec 02 '24 22:12 srl295

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

keymanapp-test-bot[bot] avatar Dec 02 '24 22:12 keymanapp-test-bot[bot]

Should this be based on epic/ldml-editor?

mcdurdin avatar Dec 03 '24 00:12 mcdurdin

Should this be based on epic/ldml-editor?

Oops, yes, thanks!

srl295 avatar Dec 03 '24 15:12 srl295

I feel like this PR is a good draft. But it needs a lot of work before it is ready to merge into the epic branch. Code that lands in an epic needs to be production ready -- with neat attachment points for follow-on PRs. We don't want commented-out code, test code, or code that will need re-review in general to land in the epic branch.

I've given some initial feedback. Hope this is not too depressing! I am excited for where this is going.

Finally, we should back-burner this work and focus on the LDML keyboard editor work as a priority. I think it might be sensible to refactor the .kpj handling in kmc into a kmc-project module and build on that. I can certainly take the changes in this PR into account if I take that on (or you can).

I got the rename in and will move this back to draft for now.

100% on quality.

srl295 avatar Dec 05 '24 19:12 srl295

I feel like this PR is a good draft. But it needs a lot of work before it is ready to merge into the epic branch. Code that lands in an epic needs to be production ready -- with neat attachment points for follow-on PRs. We don't want commented-out code, test code, or code that will need re-review in general to land in the epic branch. I've given some initial feedback. Hope this is not too depressing! I am excited for where this is going. Finally, we should back-burner this work and focus on the LDML keyboard editor work as a priority. I think it might be sensible to refactor the .kpj handling in kmc into a kmc-project module and build on that. I can certainly take the changes in this PR into account if I take that on (or you can).

I got the rename in and will move this back to draft for now.

100% on quality.

erm. The one thing about tabling this is, it's also the substrate for the visual editor.

But, I think I can make a draft PR off this draft PR. And can work on the rest separately.

srl295 avatar Dec 05 '24 19:12 srl295

OK. I'm going to let this one sit for a bit. It'll have some conflicts to work through.

srl295 avatar Dec 10 '24 17:12 srl295