keyman icon indicating copy to clipboard operation
keyman copied to clipboard

feat(developer): kmc-convert: new conversion .keylayout->kmn 😎

Open SabineSIL opened this issue 1 year ago • 3 comments

kmc-convert provides tooling to convert between various common keyboard description file formats. Each conversion will be implemented in its single, separate module (and each module will done in its own PR)

This PR will address the conversion keylayout → kmn

  • keylayout → kmn
  • xkb→ kmn
  • keylayout → ldml
  • xkb→ ldml
  • kmn→ ldml
  • msklc→ kmn
  • msklc→ ldml
  • ldml→ kmn
  • (inkey→ kmn)
  • (inkey→ ldml)

@keymanapp-test-bot skip

  • #12564

SabineSIL avatar Oct 21 '24 03:10 SabineSIL

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

keymanapp-test-bot[bot] avatar Oct 21 '24 03:10 keymanapp-test-bot[bot]

@SabineSIL tests look good!

I think the rule class issue could be addressed in the future also.

srl295 avatar Apr 08 '25 19:04 srl295

Also, skimming through the test data and definitions, it looks like all of the "unit" tests are what I'd consider to be integration-test level. I'm not seeing any small-scale tests focused on conversion of single rules, or comparison of two intermediately-processed rules for ambiguity or duplication detection.

It might help to structure things in order to permit such lower-level tests - to ensure the basics (or at least, specific cases for the basics) are working correctly, in a white-box testing style.

jahorton avatar Jul 21 '25 17:07 jahorton