keyman icon indicating copy to clipboard operation
keyman copied to clipboard

refactor(developer): refactor linter 🙀

Open srl295 opened this issue 1 year ago • 2 comments

  • simplify LdmlKeyboardCompiler.validate() by removing a redundant check

Fixes: #11054

@keymanapp-test-bot skip

Suggested by https://github.com/keymanapp/keyman/pull/11810#discussion_r1650176743

srl295 avatar Jun 24 '24 14:06 srl295

User Test Results

Test specification and instructions

User tests are not required

keymanapp-test-bot[bot] avatar Jun 24 '24 14:06 keymanapp-test-bot[bot]

Fixes: #11054

I don't understand how this PR fixes that?

Could you update the title to clarify what is being done here?

mcdurdin avatar Jun 30 '24 21:06 mcdurdin

Fixes: #11054

I don't understand how this PR fixes that?

Could you update the title to clarify what is being done here?

Updated.

I removed the "Fixes" - the feature work was in https://github.com/keymanapp/keyman/pull/11810 this is just an improvement to the fix.

srl295 avatar Aug 06 '24 14:08 srl295

Changes in this pull request will be available for download in Keyman version 18.0.92-alpha

keyman-server avatar Aug 19 '24 18:08 keyman-server