keyboards icon indicating copy to clipboard operation
keyboards copied to clipboard

Karabolpoular2, a update of Arabic keyboard karampoular

Open sven-oly opened this issue 6 months ago • 5 comments

sven-oly avatar Jun 22 '25 23:06 sven-oly

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

keyman-server avatar Jun 22 '25 23:06 keyman-server

Is this keyboard just an update to the previous version? If so, it's best just to update the existing one. We don't use versions in the filenames. If this is a completely different keyboard, then please rename it without including the version in the filename. Thanks!

On Sun, Jun 22, 2025, 6:58 PM Keyman Server @.***> wrote:

keyman-server left a comment (keymanapp/keyboards#3587) https://github.com/keymanapp/keyboards/pull/3587#issuecomment-2994544572

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/pull/3587#issuecomment-2994544572, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6RI56M354H7D4LESB4OT3E47JTAVCNFSM6AAAAAB73533ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJUGU2DINJXGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LornaSIL avatar Jun 23 '25 00:06 LornaSIL

c'est un nouveau clavier différent du premier je voudrai que les deux soient maintenus si possible. c'est le concepteur du clavier baba ibrahim ( AYOUBA BARRY)

DOUCKI56 avatar Jun 23 '25 00:06 DOUCKI56

You don't want a version number in the filename. The filename will be part of the url forever even when you update the keyboard.

On Sun, Jun 22, 2025, 7:30 PM DOUCKI56 @.***> wrote:

DOUCKI56 left a comment (keymanapp/keyboards#3587) https://github.com/keymanapp/keyboards/pull/3587#issuecomment-2994573607

c'est un nouveau clavier différent du premier je voudrai que les deux soient maintenus si possible. c'est le concepteur du clavier baba ibrahim ( AYOUBA BARRY)

— Reply to this email directly, view it on GitHub https://github.com/keymanapp/keyboards/pull/3587#issuecomment-2994573607, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABV6RIZSX6KT2BR3INJCCDL3E5DCJAVCNFSM6AAAAAB73533ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJUGU3TGNRQG4 . You are receiving this because you commented.Message ID: @.***>

LornaSIL avatar Jun 23 '25 01:06 LornaSIL

At a minimum the folder name the keyboard is in needs to be renamed from karambolpoular_version2 to karambolpoular2. But it feels to me like you are using the 2 as a version. It might be best to change the name of the folder and filenames to karambolpoular_harmonized or something like that which will distinguish it from the other keyboard. However, if you really want the keyboard name to be KARAMBOLPOULAR2 then I guess the folder and filenames can stay as karambolpoular2

I haven't checked the keyboard thoroughly yet. I'd like the folder name to be resolved first. As always, we don't require documentation when a keyboard is in experimental but it certainly would help the users to have graphics displayed in the welcome.htm file so they know how to type.

Since this is an initial submission, it would make sense if the keyboard version could be version 1.0 instead of version 2.0.

In the .kmn the targets header should be set to any rather than listing out all the targets.

LornaSIL avatar Jun 23 '25 14:06 LornaSIL

Thank you for your help, Lorna. I will close this PR and then create a new one carambolfulbhe with the new keyboard.

The new PR is here: https://github.com/keymanapp/keyboards/pull/3607

sven-oly avatar Jul 05 '25 16:07 sven-oly