keyboards icon indicating copy to clipboard operation
keyboards copied to clipboard

[sil_shan] replace U+1037 with U+1036

Open Nnyny opened this issue 6 months ago • 9 comments

fixes: https://github.com/keymanapp/keyboards/issues/3545

Nnyny avatar Jun 02 '25 09:06 Nnyny

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

keyman-server avatar Jun 02 '25 09:06 keyman-server

Since U+1036 was available on [SHIFT RALT K_H] I think it would be good to make U+1037 still available on that key so we don't significantly affect what users can and cannot do.

I'd also think we should add a note to the description that "This keyboard conforms to the 2025-May-19 Shan Standard keyboard update as announced here: https://shaniit.org/events/shan_standard_keyboard_update_announcement"

You could add that in the description of the .kps AND in the readme.htm.

Thanks!

LornaSIL avatar Jun 02 '25 14:06 LornaSIL

Noted! I'll update it soon.

Nnyny avatar Jun 03 '25 08:06 Nnyny

I have made the change. Please review again.

Nnyny avatar Jun 04 '25 03:06 Nnyny

Thanks @Nnyny There are a couple remaining issues. The OSK SHIFT and RALT SHIFT graphics need regenerating to show the change. The bigger issue that I don't know what to do about is that there are rules from line 269 down (in the kmn) where it says: c anusvara support

It feels like these are contextual rules that need to be thought about. I don't think we can just easily make the change the user requested without considering if those rules are still needed or if they need modifying in some way too.

I think we need to ask someone more knowledgeable. Let me know if you have ideas, otherwise I'll try to discuss with someone.

LornaSIL avatar Jun 04 '25 15:06 LornaSIL

I think we can keep the same rules but change it a bit to follow the original structure?

Original:

store(sdiaU)    U+1086
store(ldotU)    U+1037
+ [SHIFT RALT K_H] > U+1036

any(sdiaU) any(ldotU) + [RALT K_H] > U+1036 context
c U+1086 U+1037 RALT K_H > U+1036 U+1086 U+1037

New:

store(sdiaU)    U+1086
store(ldotU)    U+1036
+ [SHIFT RALT K_H] > U+1037

any(sdiaU) U+1037 + [RALT K_H] > U+1036 context
c U+1086 U+1037 RALT K_H > U+1036 U+1086 U+1037

Nnyny avatar Jun 05 '25 07:06 Nnyny

The OSK SHIFT and RALT SHIFT graphics need regenerating to show the change.

Also the welcome.htm assets sil_shanU_RA.png sil_shanU_S.png

I skimmed the .kmn file but I didn't immediately see where the rule for SHIFT K_H becomes U+1036

darcywong00 avatar Jun 14 '25 09:06 darcywong00

It was store as IdotU.

store(ldotU) U+1036

Nnyny avatar Jun 16 '25 01:06 Nnyny

I guess we can try your suggested changes. You'll need to commit those changes, AND the graphics for the welcome file need regenerating.

LornaSIL avatar Jun 23 '25 17:06 LornaSIL

@Nnyny will you be making these changes?

LornaSIL avatar Jul 07 '25 18:07 LornaSIL

Yes, I will work on this soon. Thanks for the reminder.

Nnyny avatar Jul 08 '25 02:07 Nnyny

It seems like changing the shift H key from U+1037 to U+1036 impact the rule greatly. @LornaSIL. please review.

Nnyny avatar Jul 10 '25 08:07 Nnyny