keyboards icon indicating copy to clipboard operation
keyboards copied to clipboard

[phoenician_basic] Initial submission

Open LinguisticalFool opened this issue 3 years ago • 2 comments

This is my first time using Github and Keyman Developer so apologies for anything I've messed up

LinguisticalFool avatar Aug 28 '22 04:08 LinguisticalFool

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

keyman-server avatar Aug 28 '22 04:08 keyman-server

Thanks for your submission! As far as I know we don't have any Phoenician keyboards in the repo, so this will be a great addition.

I haven't checked the keyboard, but I did have a few quick comments.

  • Would you be willing to call this keyboard something else? Like "Phoenician Phonetic" or "Phoenician QWERTY" or something like that? We've tended to use the name "Basic" for the keyboards we've imported (with permission) from Microsoft and I don't want to confuse this with one of those keyboards. That would require changing the name of the keyboard and hopefully all the file/folder names.
  • I think the copyright needs more than a first name.
  • I noticed you are referencing the .ico file from somewhere down in your computer's download file structure and not from the source folder as it should. That should be fixed since that file isn't in the repo
  • I noticed you've committed two .kmn files. One of them has the wrong file name. You'll need to remove one of them...the folder name and file names should be consistent.
  • Since there aren't as many characters in Phoenician as in Latin, I would choose to prevent my keyboards from producing Latin characters on the default or shift layers when those keystrokes aren't needed. So, for example, if "J" isn't needed, I will write a rule like this + [SHIFT K_J] > nul so that Latin letters aren't produced. You could do that to improve the keyboard if you wanted that behavior. This last one is optional. The others above need to be adjusted.

LornaSIL avatar Aug 29 '22 14:08 LornaSIL

Since we haven't heard back from you, I'm going to close this PR. Feel free to either reopen this Pull Request or submit a new one.

LornaSIL avatar Nov 14 '22 22:11 LornaSIL