keyboards icon indicating copy to clipboard operation
keyboards copied to clipboard

[cadmuus] Submission of a Lebanese keyboard

Open BenArzoun opened this issue 3 years ago • 5 comments

A Lebanese Latin-based keyboard inspired by Said Akl's orthography.

BenArzoun avatar May 24 '22 02:05 BenArzoun

This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR.

keyman-server avatar May 24 '22 02:05 keyman-server

I can't open the details of the failed check. It takes me to TeamCity site, and I don't have an account. How do I "Ask one of the team members to make a manual build of this PR."?

BenArzoun avatar May 24 '22 11:05 BenArzoun

@BenArzoun thanks for your submission. One of the team will review the keyboard and give you any necessary feedback before we manually kick off a build.

LornaSIL avatar May 24 '22 14:05 LornaSIL

Thanks for your keyboard submission! I'll start giving a bit of feedback, but I won't actually test the keyboard until these issues are fixed.

  • Please delete the cadmuus.ico file from the cadmuus root folder. Leave the file that is in source.
  • Please delete the cadmuus.kmn file from the cadmuus root folder. Leave the file that is in source.
  • Please delete the cadmuus.kvks file from the cadmuus root folder. Leave the file that is in source.
  • In the source folder, you have a file called cadmuus.keyman-touch-layout. Have you worked on that touch layout or is that a side effect of some experimentation. If you don't want a touch layout yet, you should delete that file. If you do want a touch layout, you should add this line to the header of the .kmn: store(&LAYOUTFILE) 'cadmuus.keyman-touch-layout'
  • If you include the touch-layout, you should change the header:
    • In the source\cadmuus.kmn file, change the header entry that says: store(&TARGETS) 'any windows macosx linux web desktop' to store(&TARGETS) 'any'
    • If you do not want the touch-layout, change the header to store(&TARGETS) 'web desktop'
  • The welcome.htm file has a paragraph end mark (right after the h1) that should be changed to <p>
  • The readme.htm has a similar issue, but it needs a paragraph end mark too, at the end of the paragraph.
  • Both welcome.htm and readme.htm need these two added at the end of the file:
</body>
</html>
  • The .kps file calls for two image files that you have not included in this pull request. You'll need to add those image files to the source folder or remove them from the .kps. If you want them included in the kmp file that is distributed they will need adding to the Pull Request.

We also like to have a source\help folder that includes a file called cadmuus.php. It is for the online help. (You can see an example of the help file with this keyboard help: https://help.keyman.com/keyboard/sil_devanagari_phonetic) I'll let you add that file. The file should look something like this:

<?php 
  $pagename = 'Cadmuus Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>
<p>
<font size="+3">Ċadmuus, nacar el xarf ta noċrȧ nexna fi. Kalliina nqaffe maᴐo.</font>
    
</p>

<h1>Keyboard Layout</h1>
</p>
	<font size="+3">Alt + A = Ȧ</font>
</p>
	<font size="+3">Alt + C = Ċ</font>
</p>
	<font size="+3">Alt + G = Ġ</font>
</p>
	<font size="+3">Alt + O = Ɔ</font>
</p>

<img src="https://i.ibb.co/ThrJc21/Keyboard-Preview-Cadmuus.png"/>

LornaSIL avatar May 24 '22 18:05 LornaSIL

@BenArzoun will you be able to fix these issues? The longer a Pull Request waits the further out of sync with master it gets. I'd like to see your keyboard updated and approved if possible.

LornaSIL avatar Aug 02 '22 14:08 LornaSIL

@BenArzoun I will close this PR since it's been so long. If you wish to reopen and fix the issues, you are welcome to do so and we will review it again.

LornaSIL avatar Aug 30 '22 18:08 LornaSIL