rust-keylime icon indicating copy to clipboard operation
rust-keylime copied to clipboard
verified publisher icon keylime

Warn if certificates in trusted_client_ca are not readable

Open THS-on opened this issue 2 years ago • 2 comments

It seems that this just silently not loads the certificate:

https://github.com/keylime/rust-keylime/blob/2f7b3ada02382eef95d718eafa934ce753a51380/keylime/src/crypto.rs#L783-L790

THS-on avatar Feb 26 '24 18:02 THS-on

The culprit is not the part of the code you pointed out: it properly raises the error when the certificate fails to load. The problem is on its caller, which is probably ignoring the error.

This will probably be fixed once I finish the error handling overhaul I'm currently working on.

ansasaki avatar Feb 27 '24 09:02 ansasaki

@ansasaki ah I see thanks for taking a deeper look.

This will probably be fixed once I finish the error handling overhaul I'm currently working on.

Awesome thank you!

THS-on avatar Feb 27 '24 11:02 THS-on