keylime icon indicating copy to clipboard operation
keylime copied to clipboard

http requests (sent by using RequestsClient) don’t use any connection timeout value

Open igurel opened this issue 3 years ago • 2 comments

Is your an issue a feature request? If so, please raise it as an enhancement

Environment

  • OS / version: Ubuntu 20
  • Processor architecture:
  • TPM Manufacturer:
  • Keylime version: d632e2a

Description

http requests (sent by using RequestsClient) don’t use any connection timeout value

Expected behavior vs. actual behavior

Default timeout should be provided while making http requests. (timeout value should ideally be configurable in keylime.conf)

Steps to reproduce problem

  1. No time out while e.g. in tenant.py#L558, tenant.py#L593](https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L593),..

Relevant logs

Attach any relevant log files that can help to debug your issue.

igurel avatar May 26 '21 17:05 igurel

Thank you for reporting your first issue. If the issue relates to a change you intend to work on, please comment with "please assign"

github-actions[bot] avatar May 26 '21 17:05 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 12:03 stale[bot]

@mpeters I believe this has been indeed solved in the latest code (e.g., timeout=self.request_timeout on all REST API calls)

maugustosilva avatar Jan 26 '23 16:01 maugustosilva

Yes is is fixed.

THS-on avatar Jan 26 '23 16:01 THS-on