keylime icon indicating copy to clipboard operation
keylime copied to clipboard

installer.sh fails to install

Open UntriexTv opened this issue 1 year ago • 5 comments

Environment

  • OS / version: Every one, apart from Fedora
  • Processor architecture: X
  • TPM Manufacturer: X
  • Keylime version: latest

Description

The installer.sh is outdated and failed to install Keylime on most of the systems I was able to test. I am already working on the fix in my fork and will create pull request as soon as it'll be discussed in this issue.

I am creating this issue, because according to documentation it's required before contributing

Steps to reproduce problem

  1. Run installer.sh on any OS apart from Fedora

UntriexTv avatar Oct 09 '24 14:10 UntriexTv

Thank you for reporting your first issue. If the issue relates to a change you intend to work on, please ask that someone assign it to you.

github-actions[bot] avatar Oct 09 '24 14:10 github-actions[bot]

Which distributions did you try exactly?

Can you check if this PR https://github.com/keylime/keylime/pull/1665 fixes it for you?

THS-on avatar Oct 10 '24 11:10 THS-on

Thank you, this is actually great. I fixed the installer for RHEL 9, working on 8. I tested Ubuntu, Debian, Fedora and Rhel8/9. Fedora was the only one that installed. I'll take the changes you made and will implement mine. Will it be okay to create pull request in the coming days?

UntriexTv avatar Oct 10 '24 11:10 UntriexTv

Definitely! Contributions to improve the installer are very welcome.

THS-on avatar Oct 10 '24 11:10 THS-on

This should fix RHEL8, didn't test RHEL7 yet, but I think there was still problem somewhere. Worked on this for little while so also took this as opportunity to organize the code. Could not test distributions anolis and alinux as I didn't find installer for them.

UntriexTv avatar Oct 21 '24 14:10 UntriexTv