keylase
New maintainer needed
I am stepping down from the maintainer role as I don't find a lot of time to work on this project any more.
Please comment on this thread if you are an active contributor, and interested in maintaining it. Hopefully the repository owner (keylase) or @Snawoot will be able to transfer collaborator permissions, once we find the next maintainer.
CC @keylase
I suggest to invite top contributors: @reloxx13 @ramhaidar @guihkx
Thank you for maintaining this awesome project for this long, and also thank you for the invite.
Unfortunately, I don't think I'm able to give this project the attention it deserves, but hopefully someone else will up for the task.
Thanks for maintaining. It would help if you posted a how to do the main work of updating to new drivers, please.
@johnthomas00
It would help if you posted a how to do the main work of updating to new drivers, please.
Usually all it takes is to check if patch from some old version works with the new version. Quite often libnvidia-encode.so even has exactly the same SHA256 hash as the previous version.
If that doesn't work, you'll have to do all patching steps from scratch. There is my old article in russian how this patch was made and there is poor english translation of it.
The gist of it is following. You'll need to step through executable code with debugger (GDB for Linux or x64dbg for Windows) and locate conditional jump responsible for checking patched feature (limit of NVENC sessions or NvFBC feature). Once that conditional jump is found, you may proceed to making sed replacement pattern for patched bytes (for Linux) or .1337 binary patch (for Windows) to make this jump unconditional, retaining offsets of all other instructions.
Thanks for mantaining this project 'till now!
I also suggest @ramhaidar if it's up to it... He's always there helping as fast as he can for the new Drivers, it would be amazing to speed up the process of merging so people can easily apply the Patch with NVC earlier than usual.
Well, I'm not very savvy about the deeper technical aspects. I'm just using the auto-patch script for the newly released Windows drivers. And I don't have a Linux machine either. :)
How difficult would this be for somebody with little experience in coding? If this question appears to be ridiculous to you, you probably know why I'm asking 😆
How difficult would this be for somebody with little experience in coding? If this question appears to be ridiculous to you, you probably know why I'm asking 😆
@PartTheSeas you can try it out and make patch for latest version yourself and see for yourself.
@Snawoot I'd love to try that, but I'd need kind of the assistance to get my head around that. If that is not a problem: With pleasure!
@Snawoot I'd love to try that, but I'd need kind of the assistance to get my head around that. If that is not a problem: With pleasure!
@PartTheSeas Can't help with that. I believe it will not work out like that.
@Snawoot yeah, unfortunately I already thought so! Would've been too nice, as I'd have the time and definitely the motivation, but sadly just a skill issue hehe
I was able to successfully extract the bytecode from the current/latest NVidia driver and update the patch.sh on my local device. Not sure how much that plays into the maintainer role, but I would certainly love to update the community with my work. Be it a simple task nonetheless, there is a demand to have this patch made compatible with current driver versions. I can keep up with NVidia. Not sure if I can keep up with myself.
I was able to successfully extract the bytecode from the current/latest NVidia driver and update the patch.sh on my local device. Not sure how much that plays into the maintainer role, but I would certainly love to update the community with my work. Be it a simple task nonetheless, there is a demand to have this patch made compatible with current driver versions. I can keep up with NVidia. Not sure if I can keep up with myself.
we found the one 🎉 I will continue to help update new patches for windows 🫡
I have submitted a few PRs when new drivers are pushed to Linux (https://github.com/keylase/nvidia-patch/commits?author=Gelmo), and intend to continue doing so at least for drivers pushed to ArchLinux and CachyOS. Occasionally, I am able to grab drivers from other distros for these changes. I also have an understanding of how to identify the relevant bytecode when existing regex patterns aren't usable (https://github.com/keylase/nvidia-patch/commit/9ad91bf92326addc87661439c21773c73838781b).
However, I cannot commit to pushing such changes in a timely manner, nor can I dedicate time to testing patched drivers that I am not personally using. I would be happy to be a part of this beyond PRs, but PRs may be where I best fit.
