keycloakify icon indicating copy to clipboard operation
keycloakify copied to clipboard

Making the build path able to be modified using a buildPath parameter

Open adover opened this issue 3 years ago • 2 comments

To address the issue raised in https://github.com/InseeFrLab/keycloakify/issues/87. This PR begins the work of making the build directory configurable.

adover avatar Apr 13 '22 20:04 adover

Hi @garronej , thanks for your feedback. I have added you to the repository. There are still some fixes left to do, hence the TODO which I have added.

Webpack outside of CRA doesn't seem to use a public folder. We need to either a) build the keycloak_static to an assets directory and pre-set it, or b) reference the static files into the file system. I need to spend some time to understand your code to see what is happening there. Could you provide any pointers on how it works? Is it just a file replacement?

adover avatar Apr 20 '22 20:04 adover

Hi @adover,
Thank you for your for your contribution.
Two things before we move on with this:

  1. I just added a new feature, the ability to customize email template, this cause a tot of conflict with this PR.
  2. Have you considered creating a theme as a standalone project?

garronej avatar Apr 20 '22 21:04 garronej

Closed for inactivity, feel free to reopen.

garronej avatar Jan 25 '23 18:01 garronej