keycloakify icon indicating copy to clipboard operation
keycloakify copied to clipboard

Build command is noisy

Open Tasyp opened this issue 3 years ago • 2 comments

The current build command is quite noisy. It logs a significant amount of text which is not always very useful in the CI context.

Should we perhaps allow to reduce this logging to the bare minimum? Let's say provide a flag -s or --silent. If you think it's a good idea, I could create a PR for it.

Tasyp avatar Aug 09 '22 13:08 Tasyp

Hi @Tasyp thank you for your proposal,
Ok, I think this is a good idea, I'll happily merge a PR but please wait a little bit, v6 is just around the corner. It will be better to add the feature for this release.
I'll ping you when I'm ready to accept your PR

garronej avatar Aug 09 '22 14:08 garronej

Okay, thanks for the response, will wait for the release then.

Tasyp avatar Aug 10 '22 08:08 Tasyp

Hi @Tasyp,
Everything is ready for your PR now if you are still willing to make it.
I documented the option to come here: https://docs.keycloakify.dev/v/v6/build-options#silent-todo This is the branch on which you should be working: https://github.com/InseeFrLab/keycloakify/tree/v6

Thanks in advance

garronej avatar Sep 05 '22 08:09 garronej

@garronej I have opened a PR for it: https://github.com/InseeFrLab/keycloakify/pull/170

Tasyp avatar Sep 08 '22 11:09 Tasyp