keycloak-ui icon indicating copy to clipboard operation
keycloak-ui copied to clipboard

Remove custom styling

Open ssilvert opened this issue 2 years ago • 4 comments

Description

We want to remove as much custom styling as possible with the goal being that we get rid of it completely and just rely on PatternFly.

See discussion.

Discussion

https://github.com/keycloak/keycloak-ui/issues/2873#issuecomment-1254768629

Issues

No response

Motivation

No response

ssilvert avatar Sep 22 '22 14:09 ssilvert

We already have as little as possible

edewit avatar Sep 27 '22 11:09 edewit

@edewit I think we can probably remove a bit more CSS. There will be cases where we can get away with 'just' PatternFly styling and utils.

jonkoops avatar Oct 04 '22 09:10 jonkoops

You mean you would rather see something like className="pf-u-mx-xl" for example then a class that we create. I disagree with this approach as that will make it impossible to change the style, when we create our own classes and set use variable it's more easy to override.

edewit avatar Oct 04 '22 11:10 edewit

They can use PatternFly CSS variables to tweak that. If folks want to change the spacing of specific elements then most likely that should be valid contribution to the upstream project, or they should be forking the repo and building out their own custom stuff.

Either way, we can't go around adding IDs and classes to elements just in case folks want to apply custom styling to them. Also because we cannot guarantee those won't change between releases.

jonkoops avatar Oct 04 '22 14:10 jonkoops