Missing fields on SAML Advanced tab

[andymunro]

Describe the bug

These fields are omitted from the Advanced Tab/Fine Grain section for SAML clients. They are included for that section for OIDC.

Logo URL URL that references a logo for the Client application.

Policy URL URL that the Relying Party Client provides to the End-User to read about how the profile data will be used.

Terms of Service URL URL that the Relying Party Client provides to the End-User to read about the Relying Party’s terms of service.

Version

18.0.2

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Anything else?

No response

[jonkoops]

@xianli123 can you verify this needs to be implemented?

[xianli123]

Hi @jonkoops @andymunro The answer is yes. We should add these 3 settings in Advanced Tab for SAML clients. And I have created an issue for this and Eric has done some work for this. Here is the original issue link: https://github.com/keycloak/keycloak-admin-ui/issues/1969

But I found these 3 settings are still missed in my console. Could you please check it on your side? Thanks!

[andymunro]

Thanks, @Xiankun Li @.***>. I don't have the final UI installed so I cannot answer that question. However. I documented these settings as I understood where they would be -- under the Settings. tab. https://www.keycloak.org/docs/latest/server_admin/index.html#settings-tab

On Sat, Jul 30, 2022 at 12:39 AM xianli123 @.***> wrote:

Hi @jonkoops https://github.com/jonkoops @andymunro https://github.com/andymunro The answer is yes. We should add these 3 settings in Advanced Tab for SAML clients. At I have created an issue for this and Eric has done some work for this. Here is the original issue link: #1969 https://github.com/keycloak/keycloak-admin-ui/issues/1969

But I found these 3 settings are still missed in my console. Could you please check it on your side? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/keycloak/keycloak-admin-ui/issues/2935#issuecomment-1200088175, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALVZY4PRON36YH7XKUU6ZCTVWSWY7ANCNFSM526YQNVA . You are receiving this because you were mentioned.Message ID: @.***>

-- Andrew Munro

Senior Technical Writer Cell: 978-844-0637

Red Hat https://www.redhat.com https://www.redhat.com

[xianli123]

@andymunro That looks good to me. Thanks! And I will recheck the original issue https://github.com/keycloak/keycloak-admin-ui/issues/1969.

[ssilvert]

@xianli123 @edewit Please close this if it is complete.