keycloak-operator icon indicating copy to clipboard operation
keycloak-operator copied to clipboard

Published 20 hours ago • verified publisher icon keycloak

KEYCLOAK-18547 Add tolerations and nodeSelector in Keycloak deployment

Open david6983 opened this issue 3 years ago • 7 comments

Fixes #408

Additional Information

  • As discussed in the mailing list, I didn't implemented the features on the PostgreSQL deployment
  • This issue is related with the pull request https://github.com/keycloak/keycloak-operator/pull/401
  • I decided to create a new Pull Request to start from a cleaner branch since the previous was forked on the master branch and I struggled making a rebase
  • I moved the tolerations and the nodeSelector in KeycloakDeploymentSpec as requested in the code review
  • I made similar changed in rhsso_deployment. Could you please tell me if it is what you requested @vmuzikar ?

Verification Steps

  • A version of the operator has been deployed in production in a Kubernetes cluster with taints on the nodes, the deployment ran succesfully.

Checklist:

david6983 avatar Feb 17 '22 19:02 david6983

@david6983 Just wanted to ask if this is still something you'd like to work on.

vmuzikar avatar Apr 20 '22 13:04 vmuzikar

Hope requested changes can be performed soon as we really need tolerations for our use-case :(

rdelcampog avatar Apr 20 '22 15:04 rdelcampog

@vmuzikar I would be glad to continue this PR. I am going to do the modification today

david6983 avatar Apr 20 '22 17:04 david6983

@vmuzikar Let me know what you think of the changes. I tried to rebase, could you tell me if I did it properly?

david6983 avatar Apr 20 '22 19:04 david6983

@david6983 Thank you for your response. There's something weird going on with the commits. I would suggest to create a new branch, cherry-pick your changes and force-push to this remote branch.

vmuzikar avatar Apr 21 '22 06:04 vmuzikar

@david6983 / @vmuzikar what is needed to merge this PR?

patlachance avatar Jul 31 '22 12:07 patlachance

I just updated the PR, and need approval to launch the tests then if everything ok maintainers can merge

On 31 Jul 2022, at 14:06, patlachance @.***> wrote:

 @david6983 / @vmuzikar what is needed to merge this PR?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

david6983 avatar Jul 31 '22 18:07 david6983

Thank you very much for you contribution. Keycloak 19 was the last version that included this legacy Operator, and with the release of Keycloak 20 the Operator reached EOL, please see our blog post on this topic. Since this PR was not ready before Keycloak 19.0.0 had been released (and we're not adding new features in micro releases), I'm closing this PR as it is no longer relevant for this Operator (or for the Realm Operator which doesn't include Keycloak CR). Thanks for your understanding. And be sure to check out our new Operator!

vmuzikar avatar Nov 03 '22 11:11 vmuzikar