Chrysalis icon indicating copy to clipboard operation
Chrysalis copied to clipboard

Layer corruption when moving keys (?)

Open The-Compiler opened this issue 11 months ago • 4 comments

Describe the bug

I'm trying to move two keys in a layer for my Atreus. Doing so seems to reproducibly corrupt my keyboard layout.

The first time this happened, I had the layout loaded from hardware (not modified in a while). Here is an older backup I have from my layout, which seems to suffice to reproduce this at least on one layer: Layout.json

To Reproduce Steps to reproduce the behavior:

  1. Load the layout from above
  2. Go to layer 3 with the F-keys:

image

  1. Shift the F-keys one to the left by reassigning them:

image

  1. Save to device and observe how holding both middle keys and trying to use the F keys now produces numbers sometimes (?), as if I was on layer 2. Various things except the primary layer seem to be broken.

  2. Close and reopen Chrysalis, the data read back from the device is broken in a similar way:

image

image

image

Here is a reexport: Layout-broken.json

Expected behavior

No such corruption. I'm not sure if there is something wrong in my initial JSON somehow (?), but apparently it also was what was stored on my device in hardware.

Debug bundle

It looks like the problem disappeared while I was trying to get a debug bundle... here it is anyways: chrysalis-debug.json

Desktop (please complete the following information):

  • OS: Archlinux
  • Chrysalis Version: 0.13.3

The-Compiler avatar Jan 14 '25 13:01 The-Compiler

Hi, Can you repro this on https://chrysalis.keyboard.io? Chrysalis has moved to the web and there's been a ton of work on reliability since 0.13.3

obra avatar Jan 14 '25 18:01 obra

I've had the same issue intermittently since updating firmware to v0.92.6+116 a week or so ago. I can't remember the previous version I had, but maybe 0.91.x.

First, it was shifting the layout of certain layers left or right several columns, wrapping around. Today it shifted all the keymaps up one row on all layers, top rows of some layers now showing up at the bottom row of layers below them. It also reset the layer names I had set except for "Base" (layer 0).

For example, here is "Base" layer. The value of the highlighted key was on the key below it (the one that now has 5). The numbers were on the top row of layer #1. The highlighted key was the only thing I changed before saving. It was Backspace on tap, Shift to "Arrows" layer when held. I changed it to just Shift to "Arrows" layer . After saving, the layer name changed from Arrows to #2, and all the keys shifted up one row, the numbers are now on the bottom row of layer "Base". Image

Other layers look to be shifted the same way.
Image

OS: Windows Chrysalis 0.13.3, desktop app Keyboard: Keyboardio Atreus Keyboard firmware: 0.92.6+116

Update: Originally I said the top rows were wrapping around to the bottom layer of the same row. But I realize now they are wrapping around to the bottom of the layer below.

tofraley avatar Jan 16 '25 18:01 tofraley

Taylor, can you replicate this with https://chrysalis.keyboard.io? The desktop app is no longer being updated.

On Thu, Jan 16, 2025 at 10:06 AM Taylor Fraley @.***> wrote:

I've had the same issue intermittently since updating to v0.92.6+116 a week or so ago. I can't remember the previous version I had, but maybe 0.91.x.

First, it was shifting the layout of certain layers left or right several columns, wrapping around. Today it shifted all the keymaps up one row on all layers, wrapping around. It also reset the layer names I had set except for "Base" (layer 0).

For example, here is "Base" layer. The value of the highlighted key was on the key below it (the one that now has 5). The numbers were on the top row. The highlighted key was the only thing I changed before saving. It was Backspace on tap, Shift to "Arrows" layer when held. I changed it to just Shift to "Arrows" layer . After saving, the layer name changed from Arrows to #2 https://github.com/keyboardio/Chrysalis/issues/2, and all the keys shifted up one row, the top row wrapped around and is now on the bottom row. image.png (view on web) https://github.com/user-attachments/assets/29374758-a17d-4387-a873-6582474f1786

Other layers look to be shifted the same way. image.png (view on web) https://github.com/user-attachments/assets/38beb93b-5619-436d-8c26-93690e188b28

OS: Windows Chrysalis 0.13.3 Keyboard: Keyboardio Atreus Keyboard firmware: 0.92.6+116

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/issues/1373#issuecomment-2596379521, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2DOIH4OR5GZ2JCM4XT2K7YIRAVCNFSM6AAAAABVE3KPSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGM3TSNJSGE . You are receiving this because you commented.Message ID: @.***>

obra avatar Jan 16 '25 18:01 obra

The web app seems to work fine. For good measure, I flashed the firmware again. There were some errors and it did a factory reset. After that, I loaded the backup of the corrupted layout, and put it all back the way it was originally. That saved to my keyboard without issue.

tofraley avatar Jan 16 '25 19:01 tofraley