Chrysalis icon indicating copy to clipboard operation
Chrysalis copied to clipboard

make key labels more legible

Open tlyu opened this issue 1 year ago • 6 comments

Increase font size for non-short key labels. This increases legibility.

Fixes #1094.

tlyu avatar Sep 28 '22 22:09 tlyu

Please check with a variety of key labels to make sure that longer labels don't overflow the key shapes.

tlyu avatar Sep 28 '22 22:09 tlyu

For the record, even with the current size, we do have some labels that overflow some keys. If this font size increase causes some more to overflow, as long as they're not commonly used labels, we should merge it nevertheless.

I'll have a closer look after some sleep.

algernon avatar Sep 28 '22 23:09 algernon

Unfortunately, this makes ShiftTo #1 overflow 1u keys on the Atreus:

Screenshot from 2022-09-29 21-24-56

If it were things like S+C+A+Control/" overflowing, I'd be fine with that. But ShiftTo #N` overflowing is something I'd consider a blocker, I'm afraid.

algernon avatar Sep 29 '22 19:09 algernon

Does 9.5px still seem to overflow on the Atreus? I think I don't have an easy way to preview it without the hardware. I might be willing to drop down to 9px, but that's starting to become almost as unreadable as 8px.

tlyu avatar Oct 05 '22 22:10 tlyu

Could we use CSS to truncate at the shape boundary?

On Wed, Oct 5, 2022 at 3:00 PM Taylor Yu @.***> wrote:

Does 9.5px still seem to overflow on the Atreus? I think I don't have an easy way to preview it without the hardware. I might be willing to drop down to 9px, but that's starting to become almost as unreadable as 8px.

— Reply to this email directly, view it on GitHub https://github.com/keyboardio/Chrysalis/pull/1110#issuecomment-1269025928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALC2EK6NAZQVAS3ZXGPZ3WBX3A7ANCNFSM6AAAAAAQYGUELA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

obra avatar Oct 05 '22 22:10 obra

Could we use CSS to truncate at the shape boundary?

Hm... we might be able to do that. But we'll need tooltips for the keys then, otherwise things will get messy very fast.

algernon avatar Oct 05 '22 23:10 algernon

Screenshot from 2022-10-25 06-26-44

9.5px looks better, but it still slightly overflows. We can fix that by moving the label a few pixels to the left, to reduce the margin there. I'll see if I can do something about that later today.

algernon avatar Oct 25 '22 04:10 algernon

Key legend sizes and keyboard both size got tweaked since this was first proposed.

obra avatar Mar 09 '24 04:03 obra