go-keybase-chat-bot icon indicating copy to clipboard operation
go-keybase-chat-bot copied to clipboard

Proposal: Parity between bot functions and Keybase API names

Open nathanmsmith opened this issue 6 years ago • 0 comments

Many of the names and functions that the go bot uses are very specific. Examples:

  • GetTextMessages (all other message types are ignored)
  • SendAttachmentByTeam

Rather than have specific functions for cases like these, I think it'd make more sense to have more general options that map 1-to-1 to the functions exposed to us by the underlying Keybase API. The TypeScript bot is a good example of this; the functionality for the above functions is implemented via read and attach, respectively.

That being said, I think there are some methods like SendMessageByTlfName that save the creation of a lot of new channel objects. Since the bot types will require a major version upgrade, I'm opening this issue to start a discussion on what function signatures it'd make sense to change in a v2.

nathanmsmith avatar Aug 23 '19 21:08 nathanmsmith