fix: fix cannot clear unread icon in taskbar issue (win10)

[candywater]

This issue has been around for a while.

On Windows 10 (22H2), Keybase couldn't clear the unread badge icon. The red notification badge would stay visible until I closed the Keybase window and reopened it from the taskbar's system tray area.

It's working properly after this fix. This error introduced from 2023 Dec 8.

[candywater]

looks like introduced by

https://github.com/keybase/client/pull/25648 https://github.com/keybase/client/pull/25648/files?file-filters%5B%5D=.tsx&show-viewed-files=true&show-deleted-files=false

file: shared/desktop/app/menu-bar.desktop.tsx

original code

mw?.setOverlayIcon(overlay, 'new activity')

new code

overlay && mw?.setOverlayIcon(Electron.nativeImage.createFromPath(overlay), 'new activity')

in original code, overlay could be null, so it worked fine but in new code after 2023 Dec 8, it will never call mw?.setOverlayIcon(null, 'new activity') so it gets errors.

[candywater]

hi @chrisnojima will this fix be included into next release ?