client icon indicating copy to clipboard operation
client copied to clipboard

Android 13 Causes Severe Lag/Jank

Open yottabit42 opened this issue 2 years ago • 8 comments

I've been testing Android 13 release candidates and Keybase suffers from severe lag/jank while in conversation thread view. This is 100% reproducible for me on a Google Pixel 6 Pro. Most often the issue presents while typing a new message, especially longer messages, but also presents when scrolling a thread with a lot of messages. Often the issue presents within 10-20 seconds after force-closing Keybase and reopening.

Android version: 13 beta 4 (RC) Keybase version: 6.0.1

yottabit42 avatar Aug 01 '22 23:08 yottabit42

Now that Android 13 is publicly launched, this bug still persists. It makes Keybase extremely difficult to use on Android.

yottabit42 avatar Aug 17 '22 14:08 yottabit42

"extremely difficult to use" = total fail

wadexyz avatar Aug 29 '22 22:08 wadexyz

Wow, thought it was just me. Nope, just recently upgraded to Android 13 and now keybase freezes every minute or so. Especially when dealing with gifs or video attachments.

gdalgas avatar Aug 30 '22 03:08 gdalgas

Add another one to this. This lag and freezing basically kills the useability. Both my Google Pixel 6 and Google Pixel 4 are suffering the same after Android 13 update, even after a full factory reset on the Pixel 4 issue persists.

austwhite avatar Sep 13 '22 04:09 austwhite

Can confirm Pixel 6 Pro and Pixel 6 having the issues after update

Completely unusable while waiting for the app to catch up

ConnectivityChris avatar Sep 13 '22 06:09 ConnectivityChris

Also having this problem. It's so bad, and so ubiquitous, that my team will likely move away from keybase if it's not resolved shortly.

friedman101 avatar Sep 17 '22 17:09 friedman101

Okay so it's not just me.

Are there any kind of workarounds until there is a fix? It's essentially unusable currently.

Edit: I tried disabling the battery optimization in the app settings and it seems to help. No idea yet on impact to battery. Guessing a lot of work happens in background threads in the app.

jhohertz avatar Sep 17 '22 18:09 jhohertz

Please feel free to upvote this - https://issuetracker.google.com/issues/246865993?pli=1

wallentx avatar Sep 20 '22 20:09 wallentx

Perfetto shows a lot of buffer stuffing jank happening when this problem surfaces. https://perfetto.dev/docs/data-sources/frametimeline#app-janks

yottabit42 avatar Sep 28 '22 18:09 yottabit42

If anyone has anything of any value to drop into that issue tracker, please do. I don't know if we'll ever get a response here, and this is unusable.

wallentx avatar Nov 10 '22 08:11 wallentx

Same problem on Pixel 6a and 7 Pro. Sometimes it works, but often stops particularly after a long sentence.

stanford-scs avatar Nov 19 '22 17:11 stanford-scs

Same problem on Pixel 6a and 7 Pro. Sometimes it works, but often stops particularly after a long sentence.

stanford-scs avatar Nov 19 '22 17:11 stanford-scs

Same problem on Pixel 6a and 7 Pro. Sometimes it works, but often stops particularly after a long sentence.

stanford-scs avatar Nov 19 '22 17:11 stanford-scs

It's been getting even worse. Now often when opening from a notification, Keybase will just open with a blank gray screen and never fully load. Need to force close and open again to recover.

yottabit42 avatar Nov 19 '22 17:11 yottabit42

Everyone in my Keybase team has moved to Discord now. Hasta la vista, Keybase. You had so much promise.

yottabit42 avatar Nov 20 '22 17:11 yottabit42

I have now upgraded my phone to a Google Pixel 7 Pro and still experience stalls and jank, although they aren't as obvious due to the increased CPU power.

gdalgas avatar Nov 29 '22 14:11 gdalgas

for whatever it's worth, disabling smooth display (120hz) in system settings seems to make it take longer to get to unusable

NireBryce avatar Jan 28 '23 23:01 NireBryce

Using the fixes in https://phab.comm.dev/D6193 I have a build that works to remove the lag issue when someone is typing. I'm not sure what the best way of making a PR for this is. It requires patching react-native (I just edited it in node_modules, but there should probably be some form of automation for this instead).

djkazic avatar Feb 02 '23 18:02 djkazic

I don't want to speak too soon, but I think Android Developer preview 14 has gotten rid of the problems for me. https://9to5google.com/2023/02/08/android-14-install-pixel/

wallentx avatar Feb 10 '23 06:02 wallentx

The developers have integrated the fix. The next update to the Play Store build should push it to everyone 🎉

djkazic avatar Mar 21 '23 14:03 djkazic

That's awesome @djkazic! I have been waiting for a fix and living with this jank for quite some time. Any idea on the release schedule for the Android Play Store? The last update was June 6, 2022.

gdalgas avatar Mar 21 '23 14:03 gdalgas

Unfortunately I am not a dev for this project so I couldn't really tell you. Also hoping for a new build on Google Play.

I've made an APK for personal use but if you would like a copy I could upload it. Note that because it is not signed, it will not update over the official Keybase app. Also, as you don't know me, you probably shouldn't trust my build, as I'm a random person from the internet.

That said, if you'd like to do your own build of the app I could put together a pastebin of the steps I took.

djkazic avatar Mar 21 '23 14:03 djkazic

Any idea which commit fixed the issue?

dahu33 avatar Mar 22 '23 00:03 dahu33

https://github.com/keybase/client/commit/2e1664bb6ab75aa894aae2051055f571cfa8a61e

djkazic avatar Mar 22 '23 01:03 djkazic

2e1664b

Thanks, so we have a fix in since Feb 7th but still no new release.

@chrisnojima @mmaxim @joshblum could you please urgently release a new Android app version or ping the person in charge? Keybase is basically unusable on Android since Android 13 was released (August 15, 2022). The bug seems to have been fixed in 2e1664b but we need a release... Thanks a lot in advance!

dahu33 avatar Mar 22 '23 01:03 dahu33

It's been unusable since well before then, for those of us that test Android with early alpha builds. Everyone I knew on Keybase has already left because the devs never noticed the problem, and then took so long to fix it. They aren't coming back.

yottabit42 avatar Mar 22 '23 01:03 yottabit42

I'm happy it's fixed, but this bug alone was responsible for my team moving from Keybase to Discord, and I don't think they're willing to come back :(

friedman101 avatar Mar 22 '23 04:03 friedman101

I don't want to speak too soon, but I think Android Developer preview 14 has gotten rid of the problems for me. https://9to5google.com/2023/02/08/android-14-install-pixel/

As a follow-up, keybase has been 100% fixed in Android 14 Developer Preview (the latest developer preview kinda sucks for general usage though).

wallentx avatar Mar 22 '23 08:03 wallentx

Unfortunately I am not a dev for this project so I couldn't really tell you. Also hoping for a new build on Google Play.

I've made an APK for personal use but if you would like a copy I could upload it. Note that because it is not signed, it will not update over the official Keybase app. Also, as you don't know me, you probably shouldn't trust my build, as I'm a random person from the internet.

That said, if you'd like to do your own build of the app I could put together a pastebin of the steps I took.

I'll take it @djkazic - whatever build your are using works for me. Thanks in advance. I'll switch back to the Play Store version when a new build is released, but sounds like there is little hope for that.

gdalgas avatar Mar 22 '23 17:03 gdalgas

Here's the build I made that I use. You'll need to uninstall your current Keybase app, otherwise signature verification will fail.

https://github.com/djkazic/client/releases/tag/invertedfix

djkazic avatar Mar 22 '23 17:03 djkazic