electron-edge icon indicating copy to clipboard operation
electron-edge copied to clipboard

MSVS 2015 support

Open paulprins opened this issue 7 years ago • 2 comments

Ported some changes from the tjanczuk/edge to move to msvs 2015 (from 13). I also switched up the prebuilt library numbers to use the electron version numbers. Also this is working with 1.6.11 for both 32 & 64 bit).

Note: Going forward that the prebuilt version numbers are for Electron, not node.

paulprins avatar Jun 30 '17 19:06 paulprins

https://github.com/kexplo/electron-edge/pull/46/commits/392a032d9697157924fd7a091dfa1298527f934d why did this? I want the electron-edge will be compatible even if the electron is updated. (Until the node version of the electron goes up) another commit is good. thanks

kexplo avatar Jul 01 '17 06:07 kexplo

I did this because electron-builder was rebuilding electron-edge with the node based versions. Yet when I built out the *.node libraries I used the following script:

node-gyp rebuild --target=1.6.11 --arch=ia32 --dist-url=https://atom.io/download/atom-shell --module_path=lib/ --python=python2.7 --msvs_version=2015
node-gyp rebuild --target=1.6.11 --arch=x64 --dist-url=https://atom.io/download/atom-shell --module_path=lib/ --python=python2.7 --msvs_version=2015

Changing the folder numbers to match the target took care of the rebuilding. I could be misunderstanding how that process works (I did not dig in to deeply with it).

It was also built with node v6.5.0

paulprins avatar Jul 01 '17 12:07 paulprins