electron-edge
electron-edge copied to clipboard
kexplo
Can't work on Electron 1.7.2!!
edge_nativeclr.node was compiled against a different Node.js version using NODE_MODULE_VERSION 53. This version of Node.js requires NODE_MODULE_VERSION 54.
From the Readme:
It is currently compatible with Electron-v1.6.2 (until node.js v7.4.0)
while Electron 1.7.2 runs on node.js v7.9.0.
@kexplo Can you update your repository to support Electron 1.7.2?
Now, I have rebuilt edge for Electron 1.7.2, directly using edge, but also wish you update your repository to support Electron 1.7.2
@rensiu Can you explain how you rebuilt it for Electron 1.7.2 please? In detail?
Go to edge package directory
Run node-gyp clean
Run node-gyp rebuild --target=1.7.2 --disturl=https://atom.io/download/electron --msvs_version=2015 --build-from-source
And that's it? No copying the built .node files from the Release folder to the folder?
@rensiu Sorry, I was very busy these days. I will try update the version soon.
Why need to copy .node files?
var fs = require('fs') , path = require('path') , builtEdge = path.resolve(__dirname, '../build/Release/' + (process.env.EDGE_USE_CORECLR || !fs.existsSync(path.resolve(__dirname, '../build/Release/edge_nativeclr.node')) ? 'edge_coreclr.node' : 'edge_nativeclr.node')) , edge;
in lib/edge.js file. @Unforgiven-wanda
@kexplo I expect the community would be happy to maintain these version bumps so you don't have to! If you could explain what is needed to update the version then we can get these updates through faster into electron-edge :)
any update on this ? would love to use this on electron 1.7.5 to allow be to use Brothers P-Touch SDK via this package
There is another module called electron-edge-js https://github.com/agracio/electron-edge-js that offers support for multiple Electron version, try it out.
