kewisch
Fix timezone convertion in case a given timezone has a RRULE in the future and the start date in the past of the datetime in question
Please correct me if I'm wrong!
It looks like that the timezone conversion logic is not properly working for the given test timezone Europe/Berlin2
The standard timezone does not apply but the daylight one does for the given datetime 2019-10-25T15:30:00Z
I'll try to come up with a fix. Please meanwhile let me know if the test assumption is correct. THX
BEGIN:VCALENDAR
PRODID:-//tzurl.org//NONSGML Olson 2012h//EN
VERSION:2.0
BEGIN:VTIMEZONE
TZID:Europe/Berlin2
BEGIN:STANDARD
DTSTART:20191027T030000
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
END:STANDARD
BEGIN:DAYLIGHT
DTSTART:20190331T020000
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
RDATE:20200329T020000
TZNAME:CEST
END:DAYLIGHT
END:VTIMEZONE
END:VCALENDAR
Looks like only the RDATE of daylight is taken into account when computing the changes array:
Coverage increased (+0.1%) to 97.088% when pulling 3e3b3c1c064c0070af9db15cd946807d3c43dacf on DeepDiver1975:test/convert-timezone into 78122e661f584ad735ce33f6f3d08d7b91c0e4eb on mozilla-comm:master.
Who can review this please? @kewisch maybe? THX a lot!
:wave: @kewisch
Thanks for the patch, I'll see what I can do to get this in soon. I need to somehow fix my overflowing github notification emails folder.
Since you may have seen some other activity here recently, I'm acknowledging that I've seen this and still have not fixed my notifications. This change is slightly to large for me to make a call right now, though I really want to get some of these PRs merged. Hoping to try again when I have a larger chunk of time.