Philipp Kewisch

Results 614 comments of Philipp Kewisch

There is a known failure test for this case, please move it out of failure_test when fixed

This sounds reasonable, though we'll have to find out in which cases to throw and where. For anyone looking into this, keep in mind that the IANA timezones, such as...

It appears BYSETPOS with YEARLY is not currently implemented. It does seem to be implemented in a stock libical, so it might be worth checking if the code can be...

I'm currently swamped with work and really want to integrate a new recurrence iterator that will drastically improve performance, but generally this sounds like something that we could integrate with...

@georgehrke check out https://dxr.mozilla.org/comm-central/source/calendar/base/backend/icaljs/calRecurrenceRule.js#41

Thanks for the offer! First of all I would try to minimize the ics in the testcase to see if it is something about the VEVENT or the VTIMEZONE. Timezone...

I think it should be allowed to quote other strings, or at least ical.js should understand that and unquote. Related but just FYI, there is also rfc6868 for alternative ways...

Oh interesting, I didn't check the code. If there is already a flag for it then there might have been a reason. I'll have to double check the rfc, and/or...

I believe this was due to various issues in parsing quoted parameters, not specific to TZID or timezones. There were a few issues fixed recently, and one more filed but...

This is still an issue and should be simple to fix. If a date is passed to iterator(), compare with `this.startDate` and take whatever is later in time. Double check...