action-web-ext icon indicating copy to clipboard operation
action-web-ext copied to clipboard

Arch dependent optional deps are not included

Open muffinresearch opened this issue 2 years ago • 1 comments

Hi @kewisch 👋, using the current rev, I'm hitting an error running the action with the action installed as a submodule local to the repo I'm using it from:

Error: Cannot find module '@node-rs/crc32-linux-x64-gnu'

This looks to be due to the arch specific deps not being part of the committed node_modules. A temporary workaround is possible by adding a step which runs npm install like so:

      - name: workaround missing dep in action-web-ext
        working-directory: .github/actions/action-web-ext
        run: npm install

muffinresearch avatar Jun 28 '23 19:06 muffinresearch

Hey, thanks for noting. This is some new dependency on yauzl-promise I believe. I really like the lib, but I don't think I am even using the rust feature they include. We should probably either downgrade the lib, or find a different one.

kewisch avatar Jun 28 '23 21:06 kewisch