Error while signing the firefox add-ons

[khuzama98]

Can you please guide me here with this issue, I have been trying to solve this but it keeps giving me a timeout error.

Error: Error: Signing took too long to complete; last status: {"guide":"<my-guid>","active":false,"automated_signing":true,"url":"https://addons.mozilla.org/api/v5/addons/guid/versions/1.0.3/uploads/209ae4ff65894279abac119e22c100d0/","files":[{"download_url":"https://addons.mozilla.org/api/v5/file/3848030/xxx-1.0.3-an+fx.xpi","hash":"sha256:010377edd327eda45cbe4797c59e84bd2ec0e9c6761c0368c719fc3e06a75555","signed":false}],"passed_review":null,"pk":"209ae4ff65894279abac119e22c100d0","processed":true,"reviewed":null,"valid":true,"valid...

Last time it ran for almost 6 hours and then gave the timeout error, the fact that I explored this error and find that the delay is caused by AMO and they updated the message explaining what the cause was, here is the link. So I think the pipeline should not be giving error in this scenario. As the pipeline give an error I'm unable to drop the artefact for the download.

Kindly guide me here. Thanks

[kewisch]

I've made some changes, can you let me know if this is still an issue with v1? It should pass with a warning that the add-on was not auto-signed.

[XFox111]

Hi, I have the same issue. It ran for full 6 hours and then was stopped by Host Agent with error The job running on runner Hosted Agent has exceeded the maximum execution time of 360 minutes

It happened yesterday (07-Sep-22) though the last time I successfully ran the pipeline was about a year ago

Here's my part of the workflow file:

Firefox:
    needs: Build
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v3

    - uses: actions/download-artifact@v3
      with:
        name: 'Build'
        path: Build

    - name: Build Extension for Firefox
      id: web-ext-build
      uses: kewisch/action-web-ext@v1
      with:
        cmd: build
        source: Build

    - name: 'Sign & publish'
      id: web-ext-sign
      uses: kewisch/action-web-ext@v1
      with:
        cmd: sign
        channel: listed
        source: ${{ steps.web-ext-build.outputs.target }}
        apiKey: ${{ secrets.FIREFOX_API_KEY }}
        apiSecret: ${{ secrets.FIREFOX_CLIENT_SECRET }}

    - name: Drop artifacts
      uses: actions/upload-artifact@v3
      with:
        name: 'Firefox'
        path: ${{ steps.web-ext-sign.outputs.target }}

I can share my logs here, but I walked it through, and it doesn't seem to have any useful info

[XFox111]

Also, I think you need to remove that 'waterfall' animation as it generates a huge number of logs and generally doesn't carry any useful information

I'm talking about these:

Validating add-on [   .                                                        ]
Validating add-on [   .        .                                               ]
Validating add-on [   .        .       .                                       ]
Validating add-on [   .        .       .      .                                ]
Validating add-on [.  .        .       .      .                                ]
Validating add-on [.  .        .       .      .                            .   ]

[XFox111]

I solved my problem

Turns out Firefox doesn't support v3 manifest which I used in my new version. I accidentally discovered it when I looked through the logs. The error message was hidden somewhere in the middle, surrounded by that 'waterfall'. It told that validation had failed and provided a link to validation result. Though right after that it resumed generating 'Validating add-on' logs

It was something like this:

Validating add-on [.. . .      . . .   . ..   .  .         .      ..  .    ..  ]
Validating add-on [.. . .      . . .   . ..   .  .         .      ... .    ..  ]
==> Error message here
Validating add-on [.. . .      . . .  .. ..   .  .         .      ... .    ..  ]
Validating add-on [.. . ..     . . .  .. ..   .  .         .      ... .    ..  ]

[kewisch]

I believe the waterfall is provided by a dependency. I guess we could look into verbosity levels, but of course we don't want to swallow other messages. And there should be a way to show it isn't stuck?

Contributions very much welcome, as I am no longer working at Mozilla and this project isn't part of my day to day.

[kewisch]

@XFox111 Could you try #29 ? The linter fails for some unknown reason, but this should make sure the progress bar does not show by default.

[XFox111]

@kewisch sure, I will keep you posted

[XFox111]

@kewisch yep. Works perfectly!