action-web-ext icon indicating copy to clipboard operation
action-web-ext copied to clipboard

don't require auth token for linting

Open LennyPenny opened this issue 3 years ago • 4 comments

would be cool if linting wouldn't require an auth token so it can run in PRs from people not part of the repo

LennyPenny avatar May 18 '21 17:05 LennyPenny

Bump. Just hit this myself too.

groovecoder avatar Aug 27 '21 15:08 groovecoder

Furthermore, when I tried to create a personal access token with public_repo permission, and provided it as the GITHUB_TOKEN env value, I got this error during the job run:

Error: HttpError: You must authenticate via a GitHub App.

groovecoder avatar Aug 27 '21 16:08 groovecoder

The action uses GITHUB_TOKEN from the env. What you could try is intentionally making it empty (e.g. setting an empty string via env in the action). I'm using the token to create check runs, so it will show one of those nice annotations. I'm not really sure why github doesn't allow this without auth.

Is this still an issue?

kewisch avatar Jan 22 '22 21:01 kewisch

I'm trying something else now, so this isn't an issue for me anymore.

groovecoder avatar Jan 24 '22 16:01 groovecoder

On 3283e6644badba1e1f08710b8f7ed5ef1625a5b6 I changed it so the check run is ignored if permissions are not there. This way the action should still fail, and you only get the fancy check run if you have permissions.

kewisch avatar Sep 14 '22 09:09 kewisch