url-regex icon indicating copy to clipboard operation
url-regex copied to clipboard

matching non existent tld

Open CheweyZ opened this issue 7 years ago • 3 comments

running urlRegex({strict: false}).test('something github.are foo bar'); returns true even though "are" isnt on the list of tld's image

CheweyZ avatar Jun 27 '18 06:06 CheweyZ

But .ar is and it matches github.ar, although it shouldn't.

mathieumg avatar Nov 08 '18 23:11 mathieumg

Well, even worse, when given 'bonjour.bonsoir' it matches bonjour.bo

yzaroui avatar Apr 23 '19 11:04 yzaroui

See my comment in #67 and my new package at https://github.com/niftylettuce/url-regex-safe. We cannot add the fix mentioned in the PR because it is a security vulnerability (as it would not allow us to use RE2 due to the described error thrown).

niftylettuce avatar Aug 15 '20 08:08 niftylettuce