Kevin Mårtensson comments

Results 107 comments of


                                            Kevin Mårtensson

Accept an `action` property in the `items` item object

Since `onSelect` returns the current item, why don't you do this: ```js const items = [{label: 'Unicorn', value: 'unicorn', action: () => {}}]; const handleSelect = item => { item.action();...

Separator item

We could export a `Symbol` and accept that in items and match against it when rendering. Don't know if it works if we accept a component directly, seems like `componentWillReceiveProps`...

Tests?

I just get 404 when trying to run this atm. Maybe GitHub has changed something?

Tests?

Yeah, I have tests ready, but it seems like something in the API is broken.

General discussion

I'm pretty sure that neither @sindresorhus or me are going to move our repos over here.

Polite/propper way to invite/fork outside projects?

Why should we create duplicate modules? If they aren't answering it's fine. We don't need to cover everything.

First invitations and thoughts about the Organization

> Not sure which suffix on the module name makes more sense `regex` is nicer imo.

First invitations and thoughts about the Organization

Regarding module patterns, just use keep using CommonJS or provide a `browser.js` file generated with browserify.

await session.save() fails to set cookie if cookies.set() is used after

@vvo, I don't have an example, but I encountered a somewhat similar issue recently. In fact, if you update the session in the middleware and try to read it in...

await session.save() fails to set cookie if cookies.set() is used after

@vvo, will submit a PR tomorrow.