Kevin Moore

icon indicating a website link https://kevmoo.com

icon company @dart-lang @flutter @google icon location Seattle, WA, USA icon location A Product Manager at @google working on @dart-lang and @flutter web technologies

Results 851 comments of Kevin Moore

Add context to Response for including file and file_not_found to be identified by other shelf Middleware.

I'd like other eyes on this change first @gmpassos

Provide some means to generate from/toJson for compatible types for other code generators

@TekExplorer – would you give some explicit, but simple code examples of the code you want to support and what you expect this package to generate for you?

Add context to `Response` for including `file` and `file_not_found` to be identified by other `shelf` `Middleware`.

i see where you're going here. I'd want to chat with @natebosch or @devoncarew on their thoughts This change should be documented and tested, too!

Add context to `Response` for including `file` and `file_not_found` to be identified by other `shelf` `Middleware`.

need changelog entry and tests

[benchmark_harness]: add a bench command

> Interesting, there's no runner currently. > > To help me get my head around the command, can you attach the output of `dart run benchmark_harness:bench -h` ? Now in...

[benchmark_harness]: add a bench command

> This PR could use a lot more documentation, explaining why things are the way they are. @mosuem – I added a bunch of docs and readme bits. Anything else...

Add `aliases` to `JsonValue` to enum value to be decoded from different JSON values

Ideally we'd have a couple of tests to validate the failure cases, but I get that those can be tricky to add.

Add `aliases` to `JsonValue` to enum value to be decoded from different JSON values

> @kevmoo What would be the failure cases for this PR? Can you give an example? Unsupported types in the set is the big one. `null` isn't supported, right? Those...

Add `aliases` to `JsonValue` to enum value to be decoded from different JSON values

You'll need to rebase this fix.

Add `aliases` to `JsonValue` to enum value to be decoded from different JSON values

FYI: I've moved this package to Dart 3.8. You'll need to rebase...