Ellabit icon indicating copy to clipboard operation
Ellabit copied to clipboard

Published 20 hours ago • verified publisher icon kevmoens

Create tests for linq queries

Open kevmoens opened this issue 2 years ago • 4 comments

kevmoens avatar Aug 08 '22 18:08 kevmoens

Is this still up for grabs?

10xJosh avatar Nov 19 '23 18:11 10xJosh

YesSent from my iPhoneOn Nov 19, 2023, at 12:56 PM, Josh Davis @.***> wrote: Is this still up for grabs?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

kevmoens avatar Nov 19 '23 21:11 kevmoens

Alright awesome! I'd love to take this one on! I'm new to contributing to open source so if you have any feedback to give me at all let me know! I really want to improve and get better!

10xJosh avatar Nov 19 '23 23:11 10xJosh

Hey Kevin!

I took a look at the code and noticed that under the "Needs Review" folder within the "Challenges" folder, there are Test methods that have

  • tmp.<rep.result1>;
  • tmp.<rep.result2>;
  • tmp.<rep.result3>;

in the return statements of the test methods. (Example: https://github.com/kevmoens/Ellabit/blob/b82f5ed47c19a06f250b013d14aaa19c4bedaa57/Ellabit/Challenges/NeedsReview/DescriptionReview/Challenge375Fareysequence.cs#L60C30-L60C48)

I wanted to confirm that its those challenges that have the <rep.result> tag in the code that are the ones that need to be created, correct?

10xJosh avatar Nov 20 '23 21:11 10xJosh