gmail-quick-links icon indicating copy to clipboard operation
gmail-quick-links copied to clipboard

Gmail changes layout again, breaks the extension

Open fireattack opened this issue 4 years ago • 20 comments

The layout is changed a little bit:

image

now the extension can no longer insert its nodes reliably:

image

fireattack avatar Feb 02 '21 02:02 fireattack

Also seeing this

chrispt avatar Feb 17 '21 13:02 chrispt

Same here.

DarkCellar avatar Feb 27 '21 04:02 DarkCellar

Yes, same here.

bennjmin avatar Mar 02 '21 08:03 bennjmin

Both my work and personal accounts are still working so I'm guessing that the gmail layout change is not global.

Can anyone try going to the developer tools and type in document.querySelector('div.wT') in the console? Does it return a DOM node? Does it highlight the left sidebar containing the "Inbox", "Starred", "Snoozed", etc. labels?

kevinwucodes avatar Mar 06 '21 17:03 kevinwucodes

According to another thread, it can be fixed by enabling Hangout (and some says that even if you disabled it later, it would still work).

So I have been using this workaround for a while. I will now disable Hangout again and see if I can reproduce this, and report back.

fireattack avatar Mar 06 '21 22:03 fireattack

I've updated the extension to v0.3.21 that provides more debugging information. In a working example, one should expect to see the following:

image

You should also see the GQL:widgetInsidePanel = false console output occur about 20 times or so. This is normal because GQL is trying to determine if you have widget panel open and sometimes that takes a bit of time to load in.

If anyone is having problems with GQL, can you post your output here so I could see where the error may be occurring?

kevinwucodes avatar Mar 07 '21 18:03 kevinwucodes

These errors would be in the Dev Console?

On Sun, Mar 7, 2021 at 1:06 PM Kevin Wu [email protected] wrote:

I've updated the extension to v0.3.21 that provides more debugging information. In a working example, one should expect to see the following:

[image: image] https://user-images.githubusercontent.com/1930629/110249753-831df800-7f2c-11eb-90eb-b8e0f787e3ff.png

You should also see the GQL:widgetInsidePanel = false console output occur about 20 times or so. This is normal because GQL is trying to determine if you have widget panel open and sometimes that takes a bit of time to load in.

If anyone is having problems with GQL, can you post your output here so I could see where the error may be occurring?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kevinwucodes/gmail-quick-links/issues/54#issuecomment-792325620, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMZ56LKZSDRKR3AKOIQS3TTCO6DRANCNFSM4W53GV4Q .

-- Chris Pohlad-Thomas

chrispt avatar Mar 07 '21 18:03 chrispt

This might be what you are looking for?

GQL:getGmailLocationToInject = false gmailNodes.js:4 GQL:getGmailLocationToInject = true gmailNodes.js:24 GQL:labelControlsContainer = false index.js:30 Uncaught TypeError: Cannot read property 'insertAdjacentElement' of undefined at injectReact (index.js:30) at index.js:89 6gmailNodes.js:38 GQL:widgetInsidePanel = false mail-ads.google.com/mail/u/0/ads/main_jspb?rt=r&client=25:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT 33gmailNodes.js:38 GQL:widgetInsidePanel = false

chrispt avatar Mar 07 '21 18:03 chrispt

Here's a screenshot. I have adblockers active, not sure if the contribute to this mess.

image

whitenoisedev avatar Mar 13 '21 16:03 whitenoisedev

Here's the output of document.querySelector('div.wT') image It does not highlight anything.

I can confirm that enabling hangouts makes it appear and disabling makes it disappear again.

whitenoisedev avatar Mar 14 '21 21:03 whitenoisedev

I did not follow up on the discussion, but yes it returns the div class node "Xa wT W8 XJ Xr" correctly.

Besides, what made me return here is the strange phenomenon that 2 or 3 days ago I saw the links again that I created with this extension, and they worked. Yet, a little later, they were gone. Today - this morning - they were again active (always right there above the inbox, as usual). I was suspicious, and I reloaded the Gmail inbox page - they were gone again. Finally, it comes down to reloading properly, using CTRL-F5 (then logging out and in again to verify if they remain). That brings them back. So in my opinion it works again.

bennjmin avatar Apr 04 '21 10:04 bennjmin

Hello!

Since 2 days ago, the extension stopped working.

Curiously, if I open the developer console (in Chromium) and refresh the gmail webpage, the extension comes back. If I close the console and refresh the webpage, the extension disappears.

Uncaught TypeError: Cannot read property 'insertAdjacentElement' of undefined at injectReact (chrome-extension://ecbkcjeoffcjnppapdlncohmehhnfibd/dist.gmailquicklinks.bundle.js:191) at chrome-extension://ecbkcjeoffcjnppapdlncohmehhnfibd/dist.gmailquicklinks.bundle.js:247

tt-hnb avatar Apr 30 '21 16:04 tt-hnb

Looks like there is another UI change. I tried refreshing and opening the developer console nothing works. It completely stopped working in Chrome.

jad00gar avatar May 17 '21 14:05 jad00gar

Broken again since latest UI update (2-3 days ago)

GitHub__Please_verify_your_device-ted_bamenda_org-_bamenda_org_Mail

tlj31962 avatar Jun 13 '21 09:06 tlj31962

If any confirmation is needed, the extension is not working for me either...

jlariviere1 avatar Jun 14 '21 21:06 jlariviere1

Google Chrome Version 91.0.4472.106 (Official Build) (x86_64) on a Mac and it stopped working too.

hotmachiato avatar Jun 16 '21 23:06 hotmachiato

Not working for me either June 17, 2021. Came here to see the status

JimmyPin avatar Jun 17 '21 19:06 JimmyPin

Hello everyone, I found a fix. Move CHAT to the right side. ( Settings -> Chat and Meet -

it works.

JimmyPin avatar Jun 17 '21 19:06 JimmyPin

Hello everyone, I found a fix. Move CHAT to the right side. ( Settings -> Chat and Meet -

it works.

This does work, but I wouldn't consider it a fix - more of a work-around. Thanks for finding it.

Mantene avatar Jun 18 '21 12:06 Mantene

Switching chat to the right indeed seems to fix the problem, but it also works once you switch back to the left again. Turning the chat feature off and on again has this same fixing effect. But after refreshing the page, the widget disappears again. So this seems to be more of a timing issue than a change in the ids of the layout elements... The 'compose' button in the top left appears to be dynamic now depending on they layout you are using. My guess is that this dynamic layout section is what is confusing the queries used by this widget.

trapperhoney avatar Jul 15 '21 13:07 trapperhoney