Kevin J. Sung

@ncrubin The definition of `number_operator` is not what you said; it's actually https://github.com/quantumlib/OpenFermion/blob/1997ea6042285339cec58c12c33a903b9ec97a30/src/openfermion/hamiltonians/special_operators.py#L273 This issue has not been fixed.

Oh, it looks like that one should be marked private, since it was defined for use in the file that contains it (and not exported).

Yeah, reviews are marked for auto-merge by adding a label, and it only works after the PR has been approved and passes CI, updating the branch my merging master if...

I agree that ideally there would be one clean commit. Unfortunately that won't be possible until #697, #716, and #730 are merged.

I don't think we should bother to implement `StarAlgebraMixin` since the user can just convert to a SecondQuantizedOp, which is more suitable for the star algebra operations and already has...

Sure, it could be useful on any class used to represent fermionic operators.

When doing these kinds of refactorings it's good to try as much as possible to preserve the version control history of each file (so `git blame` is still useful afterwards).

>However, to some degree this might not be possible because we need to actually copy instead of move the code, in order to abide by our deprecation policies. Perhaps we...

>The results still should be correct but differ from qsim results in general. @sergeisakov In the second example that I gave above, the output is actually incorrect. Changing p to...

Never mind, this wouldn't let me simulate the gates.