Kevin J. Sung

Results 133 comments of Kevin J. Sung

You can test that warnings are properly caught. An example from `ops/_symbolic_operator_test.py`: ``` def test_warnings(self): """Test that warnings are raised appropriately.""" with warnings.catch_warnings(record=True) as w: warnings.simplefilter("always") op1 = DummyOperator1() op1.isclose(op1)...

I like @jarrodmcc 's last idea. Perhaps the setting of the directory can be done with a function, like `openfermion.set_data_directory('DIRECTORY_NAME')` or something like that.

I proposed a solution specific to `ResourceCounter` in #195 . It might not be the best way. Is there any reason any other compiler engine would need to keep track...

What if we made the angle precision a property of `MainEngine`, or an attribute with getter and setter methods? Then any compiler engine can obtain the value through its reference...

I think at some point we might want to implement the basic transforms in Cython.

I'm interested in this as well. The functions for generating the Hamiltonians (in `hamiltonians/_jellium.py` and `hamiltonians/_plane_wave_hamiltonian.py`) take as part of their input a Grid object, which can have any number...

But 1/|r| is a solution to Poisson's equation for a point charge, even in 2D, right?

Based on in-person discussions, if you start with Gauss's law for 2-d (~not sure how that is physically motivated~ the physical motivation is that the electric field lines are confined...

Indeed, `jordan_wigner_interaction_op` is only guaranteed to work for Hermitian operators and is optimized based on that assumption. The InteractionOperator class is intended to represent only Hermitian operators, even though this...