react-piano icon indicating copy to clipboard operation
react-piano copied to clipboard

Allow more key combination with event.code instead?

Open Wesleyzxc opened this issue 6 years ago • 1 comments

Numpad0-9, arrow keys and navigation keys should be allowed for more keyboard shortcuts with event.code.

Wesleyzxc avatar Jun 14 '19 12:06 Wesleyzxc

That's a very good point - I didn't realize that event.code is more expressive and that event.key does not differentiate between numpad and regular numbers. I'd be happy to make a change to support this.

kevinsqi avatar Jun 21 '19 04:06 kevinsqi