Kevin Sawicki

Results 84 comments of Kevin Sawicki

I made the `HttpRequestException` constructor public in commit aeccee6

So in your example you want to send the data compressed to the server right? I think this is something useful to build into the library but I also want...

Isn't `-1` what the docs say as the end of stream? http://docs.oracle.com/javase/7/docs/api/java/io/ByteArrayInputStream.html#read()

Could you point to the line of code in `HttpRequest.java` that you think is not checking the end of streams properly?

No worries, thanks for letting me know, I want to circle back to your original point and rephrase to make sure I understand what you are looking for: In your...

Yeah, sorry, `RequestOutputStream` is internal to `HttpRequest` and is what is currently returned from `openOutput()`. I asked because the `output` field in `HttpRequest` assumes a `RequestOutputStream` and not just an...

I believe `getConnection().disconnect()` should work fine, haven't tried it though. Were you seeing issues when using it?

I think you might want to try using a custom [connection factory](https://github.com/kevinsawicki/http-request#custom-connection-factory). That way you could perform the address checks there and return a connection opened to the right URL.

So did you figure this out or are you still having issues getting it to work how you need it?

It should default to UTF-8 already, can you include an example snippet where it isn't encoding things correctly? Thanks.