Kevin Robinson
                                            Kevin Robinson
                                        
                                    And two more commits to improve the layout when there are multiple models or fields.
@jameswex This is ready for another look, or @iftenney if you have other comments please feel free to chime in as well! 👍
I realized this module was implicitly relying on the Prediction Score module to ensure that predictions are fetched when new perturbations are generated. So I pushed a commit that factors...
@alexsoble FWIW this doesn't fix this issue (or the issue in general), just for one particular bit on the profile page that was most interfering in MTSS@WH today.
It looks like there's a method https://github.com/studentinsights/studentinsights/blob/master/app/models/homeroom.rb#L12 for updating the Homeroom grade but grepping around it seems to me like it's never called. @alexsoble does any of this ring bells...
@alexsoble ha okay great thanks! That's what I thought but failed at grepping :)
This is an issue today, I patched the db manually: ### step 1, clear data bugs (I did not investigate how or why yet): ``` clear_mismatches = Homeroom.all.includes(:students).select {|homeroom| grades...
The root problem here is that a homeroom doesn't have a grade in the import, and there are mixed grade homerooms. So the approach in https://github.com/studentinsights/studentinsights/blob/master/app/models/homeroom.rb#L12 won't be accurate over...
Going to split this out of https://github.com/studentinsights/studentinsights/issues/1722 and leave it for later this summer.
Somewhat related, about validations on these values: https://github.com/studentinsights/studentinsights/issues/1941