TablerBundle icon indicating copy to clipboard operation
TablerBundle copied to clipboard

[Feature] Templating - Missing some "Widget template" from Tabler

Open cavasinf opened this issue 3 years ago • 3 comments

When using Symfony FormType and form_row() or form_widget(),

Final input render HTML are not related to Tabler.io template.

First what is input today, Second what it should be.

image

Update required in templates/layout/form-theme.html.twig and templates/layout/form-theme-horizontal.html.twig

cavasinf avatar Dec 16 '21 15:12 cavasinf

This is on the linked page: Bildschirmfoto 2021-12-16 um 16 54 31

I would prefer to use floating inputs. I have used input groups with icons for a longer time and don't think they are entirely helpful for end-users to understand the field type. Or in other cases there is simply no icon top visualize the meaning of a field.

kevinpapst avatar Dec 16 '21 15:12 kevinpapst

Understand,

The one I've showed is more flat/modern. The one you are using is more comprehensible.

How do you want to handle those different input render ?

  • Let at the current state.
  • Allow dev to choose:
    • From tabler.yml
    • Import other/new template in twig.yaml

cavasinf avatar Dec 16 '21 16:12 cavasinf

As I said: personally I would prefer to use floating inputs and then remove the icons entirely. But I haven't tested them yet, so I am not sure.

I do use my own form theme in my app, only extending the tabler one. There you can always change the look and feel. But I am not sure if it is easy right now to customize it in your own blocks.

If you have the wish to change it, please sent a PR and I will look at it. I have no strong opinion on this topic.

kevinpapst avatar Dec 16 '21 16:12 kevinpapst