TablerBundle icon indicating copy to clipboard operation
TablerBundle copied to clipboard

Card embed block names

Open cavasinf opened this issue 3 years ago • 5 comments
trafficstars

Big BC BREAK but we should rename blocks inside card embed.

https://github.com/kevinpapst/TablerBundle/blob/a2d91a62db826e770c645515286615668673cf1f/templates/embeds/card.html.twig#L24

They are called box_xxxxx as a remnant of AdminLTE. And classes card-xxxx We should stick to Bootstrap and/or Tabler name convention and use card_xxxx instead.

WDYT ?

cavasinf avatar Oct 04 '22 06:10 cavasinf

Yeah, I think that is true: but I hate the idea, considering in how many files I use these block names ^^ But we should write a wrapper that is able to handle that name change for existing installations...

kevinpapst avatar Oct 04 '22 10:10 kevinpapst

A "replace in files" CTRL + SHIFT + R from " box_" to " card_" (with a space at the beginning) should be enough? 😄

102+ ref on my side 😭 image

But we should write a wrapper that is able to handle that name change for existing installations...

And AdminLTEBundle Migration..

cavasinf avatar Oct 04 '22 11:10 cavasinf

Likely yes, but: my software supports plugins and there are many, which are not under my control... but they will have to adapt to the new theme anyway 😁 so good to go from my side.

kevinpapst avatar Oct 04 '22 11:10 kevinpapst

Changed the milestone, because this has to be done BEFORE the first "real" release.

kevinpapst avatar Oct 04 '22 11:10 kevinpapst

Please just make sure to notify me before I update ;-) well... I will find out anyway ^^

wucherpfennig avatar Oct 19 '22 18:10 wucherpfennig