Fix the KnpMenu template

[cavasinf]

Description

ATM, the KnpMenu doesn't work. Note : Knp Breadcrumb neither..

Result with the knp_menu.md example:

• Item header doesn't display :x:
• Item header have a bad style :x:
• Item parent (with child) have/need link :x:
• Badges and arrow from items are wrongly positioned :x:
• Wrong badge color used :x:
• No animation from the arrow when opening an item :x:

I've updated the template to match the AdminLTE 3 menu.

Template update (nothing too fancy):

• Changed header item type class
• Add item.label to header item display
• Changed <a> for item with child (remove 'route' required param)
• Changed badge item position & arrow item position

⚠️ Need to change your KnpMenuBuilderSubscriber.php for header items type from header to nav-header ⚠️ ->setAttribute('class', 'header'); ❌ ->setAttribute('class', 'nav-header'); ✔️

DOC update:

• Changed Header item class
• Remove route param for item with child
• Changed badge color class
• Add more generic examples with 'level' system

Result after FIX:

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [x] I updated the documentation (see here)
• [x] I agree that this code is used in AdminLTEBundle and will be published under the MIT license

[cavasinf]

ℹ️ Note ℹ️
I want to add the nav-legacy and nav-child-indent class to the menu.

The best way I've found to do it is inside KnpMenuBuilderSubscriber.php:

$menu->setChildrenAttribute('class', $menu->getChildrenAttribute('class') . " nav-legacy nav-child-indent");

Is that correct ?

[kevinpapst]

Please note that I can merge, but not answer your question as I am neither using this branch nor the KnpMenu.

[cavasinf]

I am neither using this branch nor the KnpMenu.

I can see from your Demo Repo that you have a Knp Subscriber.

Did you do your tests from there for Knp ?

[kevinpapst]

Yes, I only used KNP in the demo app. But I guess many test/use cases were not implemented there.

[kevinpapst]

Closing: I will archive this repo now