AdminLTEBundle icon indicating copy to clipboard operation
AdminLTEBundle copied to clipboard

Bootstrap table classes not loading

Open tacman opened this issue 5 years ago • 9 comments

When I add a basic table (https://getbootstrap.com/docs/4.0/content/tables/#table-head-options) to the demo home page, using standard bootstrap classes, the styling isn't applied.

    <table class="table">
        <thead class="thead-tdark">
        <tr>
            <th scope="col">#</th>
            <th scope="col">First</th>
            <th scope="col">Last</th>
            <th scope="col">Handle</th>
        </tr>
        </thead>
    </table>

image

When I try loading bootstrap separately, the table head comes out correctly, but everything else is smaller and all over the page.

tacman avatar May 12 '20 20:05 tacman

Bootstrap 4 classes in a bootstrap 3 environment doesn't work.

You need to use the v3 branch if you want bootstrap 4.

kevinpapst avatar May 12 '20 20:05 kevinpapst

I'm using this:

    "kevinpapst/adminlte-bundle": "^3",

When I use the adminlte-3 version, the knp menus fail. I spent an embarrassingly long time trying to fix that, and couldn't. Any chance you could just get knp-menu with the adminlte-3 to work? I think it's just the badge macro. Thanks.

tacman avatar May 12 '20 20:05 tacman

You can test the latest commit in the v3 branches (both demo and this repo). I fixed the knp menu problems, but please note that KNP is not yet fully functional, its still on the TODO list

kevinpapst avatar May 12 '20 23:05 kevinpapst

Thanks, Kevin, appreciate that!

Indeed, the KNP nested menus aren't working, so I'll get at least one of my sites converted over to using your menu event handler instead.

The demo app isn't working at the moment on the admin-lte3 branch. (git clone .., git checkout adminlte-3 , composer install, yarn install, yarn run encore dev (or npm run build). Something is missing, but I can't tell what.

[image: image.png]

On Tue, May 12, 2020 at 7:40 PM Kevin Papst [email protected] wrote:

You can test the latest commit in the v3 branches (both demo and this repo). I fixed the knp menu problems, but please note that KNP is not yet fully functional, its still on the TODO list

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinpapst/AdminLTEBundle/issues/135#issuecomment-627657440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQKKJJYP47PT6FM7BGTRRHM7HANCNFSM4M7EO57Q .

tacman avatar May 13 '20 10:05 tacman

the demo works fine on my end on the v3 branch, try from a fresh clone without running yarn

kevinpapst avatar May 13 '20 10:05 kevinpapst

When you say "v3", do you mean adminlte-3 or 3.0?

On Wed, May 13, 2020 at 6:37 AM Kevin Papst [email protected] wrote:

the demo works fine on my end on the v3 branch, try from a fresh clone without running yarn

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinpapst/AdminLTEBundle/issues/135#issuecomment-627899764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQNPRZW3UAVYGAAGBDLRRJ2ALANCNFSM4M7EO57Q .

tacman avatar May 13 '20 10:05 tacman

Yeah, adminlte-3 does work right out of the box, but yarn run encore dev shows this:

Running webpack ...

ERROR Failed to compile with 1 errors

           6:49:04 AM

This dependency was not found:

  • admin-lte/dist/css/AdminLTE.min.css in ./vendor/kevinpapst/adminlte-bundle/Resources/assets/admin-lte.js

On Wed, May 13, 2020 at 6:47 AM Tac Tacelosky [email protected] wrote:

When you say "v3", do you mean adminlte-3 or 3.0?

On Wed, May 13, 2020 at 6:37 AM Kevin Papst [email protected] wrote:

the demo works fine on my end on the v3 branch, try from a fresh clone without running yarn

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinpapst/AdminLTEBundle/issues/135#issuecomment-627899764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQNPRZW3UAVYGAAGBDLRRJ2ALANCNFSM4M7EO57Q .

tacman avatar May 13 '20 10:05 tacman

Interesting, never used yarn run encore dev in the last year... if you fix it, please sent a PR

kevinpapst avatar May 13 '20 10:05 kevinpapst

It seems like that's the most common practice for Symfony, no? But npm run build has the same problem.

On Wed, May 13, 2020 at 6:52 AM Kevin Papst [email protected] wrote:

Interesting, never used yarn run encore dev in the last year... if you fix it, please sent a PR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kevinpapst/AdminLTEBundle/issues/135#issuecomment-627906094, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEXIQLAAWEJMIYQF2TUCVLRRJ3W3ANCNFSM4M7EO57Q .

tacman avatar May 13 '20 11:05 tacman