vue-numeric icon indicating copy to clipboard operation
vue-numeric copied to clipboard

Fix vite build issue with import from accounting-js

Open derickdsouza opened this issue 2 years ago • 1 comments

This PR fixes a vite build issue: vite build fails while trying to optimise its dependencies because accounting-js does not export default. Using named exports fixes the issue and allows vite to optimise vue-numeric.

derickdsouza avatar Apr 14 '22 19:04 derickdsouza

Hi thanks for the PR, could you fix the merge conflict?

kevinongko avatar May 24 '22 02:05 kevinongko

This good to go in now? Just came up against this after migrating to Vite

alcoheca avatar Sep 19 '22 20:09 alcoheca

@kevinongko Could we merge this in? Looks like its good to go. As this issue is blocking the package usage with vite.

eeedvisss avatar Jun 08 '23 12:06 eeedvisss

@eeedvisss updated, cheers

kevinongko avatar Jun 11 '23 08:06 kevinongko