sfdc-trigger-framework
sfdc-trigger-framework copied to clipboard
kevinohara80
Reformat renatoliveira's patch
This started out as a reformatted PR#13 per the request from @kevinohara80 there. (I asked there if renatoliveira was OK with me submitting a reformatted version, and he said he was). I added the following changes:
- Restored the clearAllBypasses method, and made it work for either manually bypassed handlers or a globalBypass.
- Removed the new clearGlobalBypass method since 1 above handles it as well.
- Changed the isBypassed methods to return true if a globalBypass was in effect.
- Restructured the ifs in setTriggerContext to make the block a bit more efficient.
- Updated the README to include examples of bypassing a list and using globalBypass().
Yes, I thought it was odd it couldn't be turned off, but didn't think enough to change it. :) Fixed. I also fixed the global bypass example in the README. (I haven't encountered a "suggestion" before with a code change; if I could have committed it directly I apologize, I just went with what I know works. And I needed to fix the readme anyway.)
@vr8hub No problem. Thanks for the fix. Looks like there is a merge conflict that needs to be resolved before merging. If you can take care of that I can get this merged.
Well, I'm out of my depth, apparently. I've never had something change underneath me on a PR. I modified the branch to include the use of switch and fix another issue, but it still reports the same conflicts. And the two conflicts it's reporting are both changes I'm making. So I don't see how those could be conflicts. Sorry, I don't use git in a distributed environment, so I've never had to solve these types of problems.
I finally had time to investigate this and believe the conflicts are resolved.