Kevin Tindall

Results 58 comments of Kevin Tindall

Fixed by #383

We could also add enter and exit functions to enable `with` statements.

To be clear, I do see that #335 exists and I still believe that the new code should land in its already planned future home. Why would we add `PingResponse.Description`...

> When editing legacy code, follow the legacy structure. No. By this same logic, I would never do chores. While living in a dirty house, keep living in a dirty...

Let's make the placement correct from the beginning... Why are you insisting on making a mess (that you already plan to cleanup) with the _initial placement_ of this brand new...

> oh wait, I did it already in Motd.plain... Almost as if placing this code into the new class in the correct location was better in the first place... I...

@PerchunPak My life has been super busy lately. I reviewed approximately half of this 2 weeks ago. At the earliest, I will finally have time on Wednesday evening to finish...

These servers are not responding to a test ping appropriately. Is that something that was disabled on the server's side? I'm noticing that these are non-vanilla servers.

Using the same stuff that JavaServer uses, it is possible to skip that ping test which populates that latency part of the status. ```python from mcstatus.address import Address from mcstatus.pinger...

It's pretty common to show N/A for ping latencies on most games. Introducing a boolean flag to make a function do multiple things is worse in this case.