TensorKart icon indicating copy to clipboard operation
TensorKart copied to clipboard

load_imgs function missing

Open nezza opened this issue 3 years ago • 4 comments

Hello,

The load_imgs function, used in https://github.com/kevinhughes27/TensorKart/commit/6ab288dbf59add326c7ecfbf426e38d21c685f37, is missing from the codebase :)

Thanks for this awesome project!

nezza avatar Nov 05 '21 17:11 nezza

Hmm indeed it is. Code review failure on my part there. I'll see if the author of that PR has it otherwise I'd recommend reverting that commit to get it working or trying to figure out what load_imgs is supposed to do.

kevinhughes27 avatar Nov 05 '21 18:11 kevinhughes27

Thanks for the fast response!

That's what I ended up doing for now, will see if I can figure out what it's supposed to do tomorrow

Cheers!

nezza avatar Nov 05 '21 18:11 nezza

I would guess that it loads all the images for a given sample and probably returns them as a List that will get converted to numpy later. I didn't look at the fork from the PR. It is possible the code is on the fork and just wasn't merged over here.

kevinhughes27 avatar Nov 05 '21 18:11 kevinhughes27

🤞 https://github.com/kevinhughes27/TensorKart/pull/65#discussion_r743888923

kevinhughes27 avatar Nov 05 '21 18:11 kevinhughes27