agent_orange

agent_orange copied to clipboard

Upgrade to GitHub-native Dependabot

1

_Dependabot Preview will be shut down on August 3rd, 2021. In order to keep getting Dependabot updates, please merge this PR and migrate to GitHub-native Dependabot before then._ Dependabot has...

dependabot-preview[bot]

Rename Project/Gem?

10

There have been a few people over the last couple of months who have not liked the name of the project (and thus the gem). It was originally intended to...

kevinelliott

I wasn't able to easily determine how to fix the iPad scenario, but here is a possible fix: https://github.com/airolson/agent_orange/commit/fe2304817e0f6c62561b19e7793bec4c532927cf

afeld

Windows 8.1 (IE 11) is incorrect

1

on IE 11: Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; Touch; rv:11.0) like Gecko it detects engine_version, browser and browser_version as empty strings: {"platform":"windows","device":"","engine":"gecko","engine_version":"","browser":"","browser_version":""} FYI: http://msdn.microsoft.com/en-us/library/ie/bg182625%28v=vs.85%29 Thanks!

gdbtek

Bot check failing on many bots due to only checking the comment

2

Loads of bots are being missed because the bot check is only checking content[:comment] Some that are coming through for use and not being caught include: facebookexternalhit/1.1 (+http://www.facebook.com/externalhit_uatext.php) compatible; Googlebot/2.1;...

msaspence

Is there a way to detect the "top level" version of Safari? For instance, Safari 6.0.2 has a "version" of 536.26.17. I want to show `6.0.2`, though, and I can't...

Shpigford

Thanks for making this gem! I was wondering if you had considered adding search engine detection? I see that it currently checks whether something is a bot, but it would...

bloudermilk

Create a parser chain, that uses smart matchers to detect platforms/devices/etc. Base class is AgentOrange::Matcher, and contains all the rules necessary to match. Matchers are stuffed in an ordered array,...

kevinelliott

Allow developers to inject their own regex matchers for specific needs. These injections should prepend all other parsing so that their additions are prioritized. Something like this might be nice:...

kevinelliott

I added the Code Climate badge to the README, and it links to the code analysis by Code Climate. It's graded pretty poorly, since there is some redundancy code and...

kevinelliott