Fix for https://github.com/kevinchappell/formBuilder/issues/1237

[oneplugin]

Fix for https://github.com/kevinchappell/formBuilder/issues/1237

[lucasnetau]

I'm not the maintainer and won't comment on the feature, however this PR does appear to modify (and in some cases revert recent changes) many files outside of the actual change.

mkdocs.yml -> reverting previous change bower.json -> doesn't validate Dockerfile -> reverting previous change package.json -> removing production flags to webpack demo -> hardcodes changes to demo to meet this specific feature

Also there are lots of console.log calls left in the PR

[Jojoshua]

I agree @lucasnetau . It is hard to review as it is currently. Would like to see only the necessary changes.

[kevinchappell]

@oneplugin Thanks for the contribution. I can say that it is appreciated as this is a feature requested since at least 2017. It looks like it may need to be rebased with the master branch to pull in more recent changes. As it your PR would be removing links to documentation and changing the demo's focus on the bootstrap column feature. Also some of the hardcoded changes and logs in demo could be cleaned up but I do like the idea of having some column test data that can be loaded.

[oneplugin]

Thanks Kevin! It feels really good to hear nice words from the master himself.

I’d be more than happy to fix the configuration issues and remove the logs and then create another PR, if required. I had to change the test data because I added some new configuration parameters like properties in bootstrap dialogue, maximum number of columns and stuff. But they all have default values and hence I can revert to the same configuration you had earlier.

So just let me know what needs to be done.

On Tue, 18 Jan 2022 at 5:04 AM, Kevin Chappell @.***> wrote:

@oneplugin https://github.com/oneplugin Thanks for the contribution. I can say that it is appreciated as this is a feature requested since at least 2017. It looks like it may need to be rebased with the master branch to pull in more recent changes. As it your PR would be removing links to documentation and changing the demo's focus on the bootstrap column feature. Also some of the hardcoded changes and logs https://github.com/kevinchappell/formBuilder/pull/1238/files#diff-6a71dfffeacaa39ce824e33fea5e0046e2304f140a63243c077e7fce2b18497bR13 in demo could be cleaned up but I do like the idea of having some column test data that can be loaded.

— Reply to this email directly, view it on GitHub https://github.com/kevinchappell/formBuilder/pull/1238#issuecomment-1014955103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7ZQQBOG5H2FLBUHA76IJTUWSRQBANCNFSM5KFQ3U4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[Obaidraj]

Uncaught TypeError: jquery__WEBPACK_IMPORTED_MODULE_1__(...).formBuilder is not a function in react i am facing this issue how can I resolve.

[kevinchappell]

@oneplugin all good and much appreciated. I totally understand about the test data, a standardized method for providing test data is something that needs improvement in the project.

Re: fixing up the PR: that would be great and I love the work that both you and @Jojoshua did on adding grid support to formBuilder. I would like to incorporate both of your works into the project and I think it can be done via configuration... for now. A better more long-term solution would be to have "addon" support so large features like these would essentially be a plugin for formBuilder. This would keep the core formBuilder filesize down while still enabling the features for those that need it.

For now though a gridSupport option could be used to enable and configure the grid/column support features. Example:

const options = {
  gridSupport: {
    method: 'oneplugin' // or 'Jojoshua'
  }
}

and to disable

const options = {
  gridSupport: false // default
}

Having the option config as an object provides space for other potential settings but I am open to it being just a string too eg:

const options = {
  gridSupport: 'oneplugin'
}

[oneplugin]

@kevinchappel - IMHO the plugin model is the way to go but that will require rewriting the current code base to support modules. But if done that will reduce the library footprint and will be much more welcoming from the adopters side.

I see that @Jojoshua has been pushing updates to the current build to make it support multi columns and I want him to know that I truly and selflessly appreciate his efforts.

I’m also willing to contribute by revamping what I did in a much more efficient way. I started working on d&d with multi column support because I had a requirement at that time but that project is in the back burner for now.

Having said that I’m happy to help in whatever way and capacity I can. Just let me know.

Cheers Jugs

On Tue, 8 Mar 2022 at 11:26 PM, Kevin Chappell @.***> wrote:

@oneplugin https://github.com/oneplugin all good and much appreciated. I totally understand about the test data, a standardized method for providing test data is something that needs improvement in the project.

Re: fixing up the PR: that would be great and I love the work that both you and @Jojoshua https://github.com/Jojoshua did on adding grid support to formBuilder. I would like to incorporate both of your works into the project and I think it can be done via configuration... for now. A better more long-term solution would be to have "addon" support so large features like these would essentially be a plugin for formBuilder. This would keep the core formBuilder filesize down while still enabling the features for those that need it.

For now though a gridSupport option could be used to enable and configure the grid/column support features. Example:

const options = { gridSupport: { method: 'oneplugin' // or 'Jojoshua' }}

and to disable

const options = { gridSupport: false // default}

Having the option config as an object provides space for other potential settings but I am open to it being just a string too eg:

const options = { gridSupport: 'oneplugin'}

— Reply to this email directly, view it on GitHub https://github.com/kevinchappell/formBuilder/pull/1238#issuecomment-1062049368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7ZQQAI7ZZGYQZI7IZMI4TU66IDTANCNFSM5KFQ3U4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[oneplugin]

@kevinchappell @Jojoshua A question to both of you. Does it make sense to create native iOS and Android app that can render the forms(natively) designed using this form builder?

And may be a generic API as well to submit the data, which will be stored as json and can be retrieved when required.

if it sounds interesting, I can write both the iOS and Android counterpart for this form builder.

[Jojoshua]

@kevinchappell @Jojoshua A question to both of you. Does it make sense to create native iOS and Android app that can render the forms(natively) designed using this form builder?

And may be a generic API as well to submit the data, which will be stored as json and can be retrieved when required.

if it sounds interesting, I can write both the iOS and Android counterpart for this form builder.

It does sound interesting. That would allow for offline form scenarios. You would want the json structure for setting the data and getting the user data to be identical so that when it comes time to sync the data(returning online) the existing server side and/or database is the same regardless if it came from a device or the browser.

I'm curios, would you be writing ios and Android as separate code bases or use something like xamarin to keep a single code base?

[kevinchappell]

@oneplugin Native mobile app support for rendering formBuilder data would be awesome! I have done react native and swift development and a formBuilder component may be valuable to some devs.

[oneplugin]

@kevinchappell @jojoshua I’m planning to do native apps on iOS and Android. I like React Native but as you all know RN uses serialised messages and asynchronous queues(the Bridge as they call it) to pass event details to the native realm and this often results in serious performance issues especially if we have larger forms that require scrolling.

So any day I will go with native apps if there is a choice. But if both of you prefer RN, then I will be more than happy to contribute.

On Fri, 11 Mar 2022 at 8:54 AM, Kevin Chappell @.***> wrote:

@oneplugin https://github.com/oneplugin Native mobile app support for rendering formBuilder data would be awesome! I have done react native and swift development and a formBuilder component may be valuable to some devs.

— Reply to this email directly, view it on GitHub https://github.com/kevinchappell/formBuilder/pull/1238#issuecomment-1064735536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7ZQQCFWILYXBELZYN5SLTU7K4H7ANCNFSM5KFQ3U4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[Jojoshua]

@kevinchappell @Jojoshua I’m planning to do native apps on iOS and Android. I like React Native but as you all know RN uses serialised messages and asynchronous queues(the Bridge as they call it) to pass event details to the native realm and this often results in serious performance issues especially if we have larger forms that require scrolling. So any day I will go with native apps if there is a choice. But if both of you prefer RN, then I will be more than happy to contribute. … On Fri, 11 Mar 2022 at 8:54 AM, Kevin Chappell @.> wrote: @oneplugin https://github.com/oneplugin Native mobile app support for rendering formBuilder data would be awesome! I have done react native and swift development and a formBuilder component may be valuable to some devs. — Reply to this email directly, view it on GitHub <#1238 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7ZQQCFWILYXBELZYN5SLTU7K4H7ANCNFSM5KFQ3U4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

@oneplugin I was only curious what you were going with as there are many options to choose from.

[kevinchappell]

@oneplugin native development is certainly better for performance, i only mention react native because i have more experience with it and could contribute more. Let's go with Native 👍

[marcoheine]

@oneplugin

Hey, https://min.gitcdn.link/cdn/oneplugin/static/main/formbuilder.min.js is not able anymore. I need your formbuilder.min.js urgent.

Can you tell me how to get there? Thanks!